View Issue Details

IDProjectCategoryView StatusLast Update
0005788Talerbank (demonstrator)public2019-11-16 03:15
ReporterMarcello StanisciAssigned ToMarcello Stanisci 
PrioritynormalSeveritycrashReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionSVN HEAD 
Target Version0.6Fixed in Version 
Summary0005788: Malformed JSON on POST makes bank crash.
DescriptionPOSTing malformed JSONs to those endpoints that process authentication credentials
make bank terminate with unhandled exception.

  File "/home/marcello/prog/taler/bank/talerbank/app/views.py", line 621, in _decorator
    user_account = auth_and_login(request)
  File "/home/marcello/prog/taler/bank/talerbank/app/views.py", line 837, in auth_and_login
    data = json.loads(request.body.decode("utf-8"))
  File "/usr/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.7/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ':' delimiter: line 1 column 68 (char 67)
Steps To ReproducePOST malformed JSON (e.g.: {"a":1, "b"}) to any API call that takes login credentials.
TagsNo tags attached.

Relationships

related to 0005787 resolvedMarcello Stanisci Make exception handling less confusing. 

Activities

Christian Grothoff

2019-09-16 09:50

manager   ~0014905

I guess given the relationship to 0005787, Marcello should fix this one after all ;-).

Marcello Stanisci

2019-11-16 03:15

manager   ~0015077

bcb36f8..fd5b3e7 fixes this

Issue History

Date Modified Username Field Change
2019-06-30 23:14 Marcello Stanisci New Issue
2019-06-30 23:14 Marcello Stanisci Status new => assigned
2019-06-30 23:14 Marcello Stanisci Assigned To => Marcello Stanisci
2019-09-16 09:48 Christian Grothoff Severity minor => crash
2019-09-16 09:48 Christian Grothoff Product Version => SVN HEAD
2019-09-16 09:48 Christian Grothoff Target Version => 0.6
2019-09-16 09:48 Christian Grothoff Assigned To Marcello Stanisci => Christian Grothoff
2019-09-16 09:49 Christian Grothoff Relationship added related to 0005787
2019-09-16 09:50 Christian Grothoff Note Added: 0014905
2019-09-16 09:50 Christian Grothoff Assigned To Christian Grothoff => Marcello Stanisci
2019-11-16 03:15 Marcello Stanisci Note Added: 0015077
2019-11-16 03:15 Marcello Stanisci Status assigned => resolved
2019-11-16 03:15 Marcello Stanisci Resolution open => fixed