View Issue Details

IDProjectCategoryView StatusLast Update
0005787Talerbank (demonstrator)public2019-09-16 09:50
ReporterMarcello StanisciAssigned ToMarcello Stanisci 
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product VersionSVN HEAD 
Target Version0.6Fixed in Version 
Summary0005787: Make exception handling less confusing.
DescriptionException handling is ALL put into the middleware module, which makes hard to map exceptions to where those occur in the code. Also, the code errors are computed with a unnecessary/easy-to-break/cryptic arithmetic ([1]). Ultimately, new-comers who aren't aware of this module will naturally put their handlers NOT in that module, resulting in a mixed exception-handling style!

The suggestion is to place obvious exception handlers in the middleware module (malformed JSON / "bad requests" / ..), and spread other less obvious exceptions handlers to where in the code those could be raised.

[1] https://git.taler.net/bank.git/tree/talerbank/app/middleware.py#n149
TagsNo tags attached.

Relationships

related to 0005788 assignedMarcello Stanisci Malformed JSON on POST makes bank crash. 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-06-30 23:07 Marcello Stanisci New Issue
2019-06-30 23:07 Marcello Stanisci Status new => assigned
2019-06-30 23:07 Marcello Stanisci Assigned To => Marcello Stanisci
2019-09-16 09:49 Christian Grothoff Relationship added related to 0005788
2019-09-16 09:50 Christian Grothoff Product Version => SVN HEAD
2019-09-16 09:50 Christian Grothoff Target Version => 0.6