View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004013TalerMerchant frontends (Python3)public2015-10-20 14:212024-01-12 14:08
ReporterMarcello Stanisci Assigned ToMarcello Stanisci  
PriorityhighSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004013: Code modifications
DescriptionTwo are the main points for this issue:

1) As of now, the merchant backend is a unique function called 'url_handler'
which serves all the requests, and defines *a lot* of variables on the stack.
The modification should define a dedicated handler for each "/x" made available
 by the merchant, in order to make 'url_handler' more light. (ADDED)

2) The merchant should monitor the reference count of each 'json_t *'
type used
TagsNo tags attached.

Relationships

related to 0004021 closedMarcello Stanisci Backend modifications to match new API 
related to 0004012 closedMarcello Stanisci Verify deposit confirmation signature 
related to 0004011 closedMarcello Stanisci Get mint's "/keys" 
related to 0004016 closedMarcello Stanisci Change implementation 

Activities

Marcello Stanisci

2015-10-20 14:55

reporter   ~0009757

Last edited: 2015-10-27 10:09

 3) correcting compilation 'warnings' (FIXED)

Marcello Stanisci

2015-10-20 15:12

reporter   ~0009758

Last edited: 2015-10-23 17:56

 4) convert various 'printf's in 'GNUNET_log's
- See https://gnunet.org/logging for instructions on how to enable and configure this facility

update: configure ignores

 --enable-logging
 --enable-logging=verbose

Marcello Stanisci

2015-10-23 15:01

reporter   ~0009780

Last edited: 2015-10-23 15:03

 'related to' as in 'fix before' (the issues it got related to).

Marcello Stanisci

2015-10-23 21:02

reporter   ~0009785

Last edited: 2015-11-03 17:49

 5) Define struct(s) to group recurrent data "aggregates" in the code.

This modification makes functions taking n+j argument, take just
j+1, by substituting n arguments belonging to the same aggregate with
some 'struct' which groupes them.

For example, define a 'struct' which represents a contract in DB.

NOTE: the refactored merchant doesn't use anything from the "old" library,
so this hint doesn't apply. (ADDED)

Marcello Stanisci

2015-10-30 07:42

reporter   ~0009861

point 1) ADDED

Marcello Stanisci

2015-11-17 14:52

reporter   ~0009915

***BUG UPDATE:***

the points still applying are:

1) count 'json_t *' references
2) get GNUNET_ERROR_TYPE_INFO printed

Christian Grothoff

2015-11-17 15:27

manager   ~0009918

Run
$ export GNUNET_FORCE_LOG=";;;;INFO"
before running command, and you'll see those.

Christian Grothoff

2015-11-17 15:28

manager   ~0009919

GNUNET_log_setup() sets the "minimal" log level globally, with the export you override. See https://gnunet.org/logging

Christian Grothoff

2015-11-27 21:30

manager   ~0009953

I think this is all fine now.

Issue History

Date Modified Username Field Change
2015-10-20 14:21 Marcello Stanisci New Issue
2015-10-20 14:21 Marcello Stanisci Status new => assigned
2015-10-20 14:21 Marcello Stanisci Assigned To => Marcello Stanisci
2015-10-20 14:55 Marcello Stanisci Note Added: 0009757
2015-10-20 15:12 Marcello Stanisci Note Added: 0009758
2015-10-23 01:12 Christian Grothoff Severity minor => tweak
2015-10-23 01:12 Christian Grothoff Product Version => 0.0
2015-10-23 01:12 Christian Grothoff Target Version => 0.0
2015-10-23 14:56 Marcello Stanisci Relationship added related to 0004021
2015-10-23 14:57 Marcello Stanisci Relationship added related to 0004012
2015-10-23 14:57 Marcello Stanisci Relationship added related to 0004011
2015-10-23 15:01 Marcello Stanisci Note Added: 0009780
2015-10-23 15:03 Marcello Stanisci Note Edited: 0009780
2015-10-23 15:15 Marcello Stanisci Relationship added related to 0004016
2015-10-23 15:16 Marcello Stanisci Priority normal => high
2015-10-23 17:19 Marcello Stanisci Note Edited: 0009758
2015-10-23 17:56 Marcello Stanisci Note Edited: 0009758
2015-10-23 21:02 Marcello Stanisci Note Added: 0009785
2015-10-27 10:09 Marcello Stanisci Note Edited: 0009757
2015-10-30 07:42 Marcello Stanisci Note Added: 0009861
2015-11-03 17:49 Marcello Stanisci Note Edited: 0009785
2015-11-03 17:49 Marcello Stanisci Note Edited: 0009785
2015-11-03 17:53 Marcello Stanisci Description Updated
2015-11-17 14:52 Marcello Stanisci Note Added: 0009915
2015-11-17 15:27 Christian Grothoff Note Added: 0009918
2015-11-17 15:28 Christian Grothoff Note Added: 0009919
2015-11-27 21:30 Christian Grothoff Note Added: 0009953
2015-11-27 21:30 Christian Grothoff Status assigned => resolved
2015-11-27 21:30 Christian Grothoff Fixed in Version => 0.0
2015-11-27 21:30 Christian Grothoff Resolution open => fixed
2015-11-28 22:28 Christian Grothoff Status resolved => closed
2015-11-29 13:48 Christian Grothoff Category merchant (demonstrator) => merchant frontend (demonstrator)
2016-02-17 03:24 Florian Dold Category merchant frontend (demonstrator) => merchant frontend (donations)
2024-01-12 14:08 Christian Grothoff Category merchant frontend (donations) => Merchant frontends (Python3)