View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005412 | Taler | obsolete component | public | 2018-07-28 17:14 | 2019-12-20 19:12 |
| Reporter | Torsten Grothoff | Assigned To | Marcello Stanisci | ||
| Priority | low | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005412: Negative Balance | ||||
| Description | Get a negative balance | ||||
| Steps To Reproduce | transfer more money then you have to any bank account using donation thing; | ||||
| Tags | No tags attached. | ||||
|
|
After you transfer 'more money than you have', the balance turns negative, and we did want this feature. |
|
|
Still open send the account 1 a large amount of kudos and it will work as long as it is not an intiger overflow |
|
|
Okay; but if the problem is a integer overflow, then it is something _different_ and so it should be filed in a dedicated bug. Thanks for reporting though. |
|
|
Ok, I checked with Torsten, and the issue does not actually seem to be an Integer overflow (in test) [anymore]. Torsten's issue is that the balance can go _very_ deep into the negative, and while I agree with Marcello that we should support negative balances (after all, real bank accounts can go into the red), we also did mention having a "credit limit", i.e. a maximum amount by which one can go into the red. I _thought_ we had a (credit) limit on withdraw, but just now tested it (on demo) and could go up to -120 KUDOS balance. So let's re-interpret this bug as a feature request that accounts (other than the exchange) should have an _effective_ credit limit (say -20 KUDOS) that ought to be enforced for exchange withdraw and wire transfer dialogs. This will be useful to test error handling for failed exchange withdraws due to 'bank refused' (in which case the wallet should simply not get the final notification from the bank and thus then never start to withdraw from the reserve; the interesting logic here is more that the wallet should eventually discard the reserve private key that was never put into action as the reserve was never filled). |
|
|
Fine. The bank logic does enforce negative limits, I'm pretty sure that the configuration is responsible now. IIRC, there is a "max_debt" option that lets you decide what is the debt threshold allowed for any user, and if it's set as "zero" it goes limit-less. |
|
|
Ok, then we should just set that limit to 20, to make it "real" ;-) |
|
|
91e69fe77baa2abba30 gives -20 debit for all bank _customers_. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-07-28 17:14 | Torsten Grothoff | New Issue | |
| 2018-07-28 17:14 | Torsten Grothoff | Status | new => assigned |
| 2018-07-28 17:14 | Torsten Grothoff | Assigned To | => Marcello Stanisci |
| 2018-07-29 10:05 | Marcello Stanisci | Note Added: 0013163 | |
| 2018-07-29 10:05 | Marcello Stanisci | Status | assigned => resolved |
| 2018-07-29 10:05 | Marcello Stanisci | Resolution | open => no change required |
| 2018-08-01 21:25 | Torsten Grothoff | Status | resolved => feedback |
| 2018-08-01 21:25 | Torsten Grothoff | Resolution | no change required => reopened |
| 2018-08-01 21:25 | Torsten Grothoff | Note Added: 0013165 | |
| 2018-08-01 21:51 | Marcello Stanisci | Note Added: 0013166 | |
| 2018-08-02 08:57 | Christian Grothoff | Note Added: 0013167 | |
| 2018-08-02 08:57 | Christian Grothoff | Priority | normal => low |
| 2018-08-02 08:57 | Christian Grothoff | Severity | minor => feature |
| 2018-08-02 08:57 | Christian Grothoff | Status | feedback => assigned |
| 2018-08-02 10:26 | Marcello Stanisci | Note Added: 0013168 | |
| 2018-08-02 10:37 | Christian Grothoff | Note Added: 0013172 | |
| 2018-09-21 14:35 | Marcello Stanisci | Status | assigned => resolved |
| 2018-09-21 14:35 | Marcello Stanisci | Resolution | reopened => fixed |
| 2018-09-21 14:35 | Marcello Stanisci | Note Added: 0013252 | |
| 2018-11-18 00:37 | Christian Grothoff | Product Version | => git (master) |
| 2018-11-18 00:37 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2018-11-18 00:37 | Christian Grothoff | Target Version | => 0.6 |
| 2019-12-20 19:12 | Christian Grothoff | Status | resolved => closed |
| 2022-08-23 20:26 | Christian Grothoff | Category | bank (demonstrator) => py bank (demonstrator, obsolete) |
| 2023-12-03 01:23 | Christian Grothoff | Category | py bank (demonstrator, obsolete) => obsolete componet |
| 2023-12-11 20:08 | Florian Dold | Category | obsolete componet => obsolete component |
