View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005284 | Taler | merchant backend | public | 2018-02-21 13:21 | 2019-12-20 19:12 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | ||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.6 | Fixed in Version | 0.6 | ||
| Summary | 0005284: Take curl context out of arguments from test instructions. | ||||
| Description | All test instructions take the usual GNUNET_CURL_Context among their arguments, when the instruction is initialized. Since those test instructions also get hold of the interpreter state, they could simply retrieve the curl context from there, so there is no need to pass the curl context among the arguments. WARNING: this issue might NOT apply to _all_ test instructions. | ||||
| Tags | No tags attached. | ||||
|
|
The same applies for the exchange handle (struct TALER_EXCHANGE_Handle *) which is also kept within the interpreter state but is passed as argument too. If this note is a real improvement, then consider adapting the _exchange_ test cases too. |
|
|
I agree, duplicating this in each command and in the interpreter state is ugly. |
|
|
b78b991 clears the merchant. Keeping it open until the exchange's code also gets cleared (see note 12886). |
|
|
b22b36a2 clears the exchange, and ee7f59d does the merchant after exchange's changes. Closing. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2018-02-21 13:21 | Marcello Stanisci | New Issue | |
| 2018-02-21 13:21 | Marcello Stanisci | Status | new => assigned |
| 2018-02-21 13:21 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2018-02-21 13:22 | Marcello Stanisci | Severity | minor => tweak |
| 2018-02-21 13:22 | Marcello Stanisci | Description Updated | |
| 2018-02-21 16:20 | Marcello Stanisci | Note Added: 0012866 | |
| 2018-02-21 16:21 | Marcello Stanisci | Note Edited: 0012866 | |
| 2018-02-21 16:21 | Marcello Stanisci | Note Edited: 0012866 | |
| 2018-11-18 00:49 | Christian Grothoff | Note Added: 0013345 | |
| 2018-11-18 00:49 | Christian Grothoff | Product Version | => git (master) |
| 2018-11-18 00:49 | Christian Grothoff | Target Version | => 0.7.1 |
| 2018-12-18 15:13 | Marcello Stanisci | Note Added: 0013418 | |
| 2018-12-18 18:27 | Marcello Stanisci | Note Added: 0013419 | |
| 2018-12-18 18:27 | Marcello Stanisci | Status | assigned => resolved |
| 2018-12-18 18:27 | Marcello Stanisci | Resolution | open => fixed |
| 2019-01-31 19:33 | Christian Grothoff | Fixed in Version | => 0.6 |
| 2019-01-31 19:33 | Christian Grothoff | Target Version | 0.7.1 => 0.6 |
| 2019-12-20 19:12 | Christian Grothoff | Status | resolved => closed |
| 2025-03-22 14:09 | Christian Grothoff | Category | mechant backend => merchant backend |
