View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005232 | Taler | mechant backend | public | 2017-12-31 01:08 | 2021-08-24 16:23 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.4 | ||||
| Target Version | 0.7.1 | Fixed in Version | 0.7.1 | ||
| Summary | 0005232: Tip reserve's expiration date not respected. | ||||
| Description | Although the Buildbot successfully topped the tip reserve up ([1]), the merchant complained about the tip reserve being "expired": { "code": 2702, "error": "Database error approving tip" } [1]: https://buildbot.taler.net/#/builders/8/builds/7 | ||||
| Tags | No tags attached. | ||||
|
|
Couldn't reproduce this anymore; changing to 'feedback' status. |
|
|
/tip-enable is being removed right now, which may further change the situation. Let's keep this one open (until 0.7) to see if it shows up again _after_ the latest changes (not yet pushed). |
|
|
Led to the discovering of other problems: Sep 21 14:13:19-145635 taler-exchange-wirewatch-28835 WARNING Did NOT detect response as JSON Sep 21 14:13:19-145659 taler-exchange-wirewatch-28835 ERROR Unexpected response code 307 Sep 21 14:13:19-145667 taler-exchange-wirewatch-28835 ERROR Assertion failed at bank_api_reject.c:127. Sep 21 14:13:19-145676 taler-exchange-wirewatch-28835 WARNING External protocol violation detected at bank_api_common.c:141. Sep 21 14:13:19-145683 taler-exchange-wirewatch-28835 ERROR Failed to wire back transfer `issue x': 1 Sep 21 14:22:05-586724 taler-exchange-wirewatch-29806 INFO Adding wire transfer over TESTKUDOS:25.05 with subject `G5G5WSET' Sep 21 14:22:05-587473 taler-exchange-wirewatch-29806 INFO Creating reserve G5G5WSET with expiration in 28 days Sep 21 14:22:05-588320 taler-exchange-wirewatch-29806 INFO Adding wire transfer over TESTKUDOS:100 with subject `M11JRHBD' Sep 21 14:22:05-588542 taler-exchange-wirewatch-29806 INFO Creating reserve M11JRHBD with expiration in 28 days Sep 21 14:22:05-588911 taler-exchange-wirewatch-29806 INFO Adding wire transfer over TESTKUDOS:100 with subject `M11JRHBD' Sep 21 14:22:05-589115 taler-exchange-wirewatch-29806 INFO Creating reserve M11JRHBD with expiration in 28 days Sep 21 14:22:05-589533 taler-exchange-wirewatch-29806 WARNING Wire transfer over TESTKUDOS:4 has invalid subject `issue x', sending it back! Sep 21 14:22:05-597378 taler-exchange-wirewatch-29806 WARNING Did NOT detect response as JSON Sep 21 14:22:05-597421 taler-exchange-wirewatch-29806 ERROR Unexpected response code 307 Sep 21 14:22:05-597436 taler-exchange-wirewatch-29806 ERROR Assertion failed at bank_api_reject.c:127. Sep 21 14:22:05-597455 taler-exchange-wirewatch-29806 WARNING External protocol violation detected at bank_api_common.c:141. Sep 21 14:22:05-597470 taler-exchange-wirewatch-29806 ERROR Failed to wire back transfer `issue x': 1 Such issue should make 0004402 more important! |
|
|
I reconfirm that I canNOT reproduce the "database error" problem. For the further error logs pasted, they witness that our logic didn't handle the 307 http response code. This code is a redirect for POST requests, and it instructs the client to not change the request method for the subsequent request. Apparently, libcurl doesn't handle this code transparently, and since our bank-lib doesn't handle it neither, it logs those errors. A viable solution migth be to enable the CUROPT_FOLLOWLOCATION option - disabled by default - , since the manpage says that "All other 3xx codes [other than 301/2/3] will make libcurl send the same method again". |
|
|
Addressed here 3b4d761f3b953367bc67635. I would say this can be closed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-12-31 01:08 | Marcello Stanisci | New Issue | |
| 2017-12-31 01:08 | Marcello Stanisci | Status | new => assigned |
| 2017-12-31 01:08 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2017-12-31 01:08 | Marcello Stanisci | Summary | Expiration date not respected => Tip reserve's expiration date not respected. |
| 2018-01-04 14:36 | Marcello Stanisci | Note Added: 0012725 | |
| 2018-01-04 14:36 | Marcello Stanisci | Status | assigned => feedback |
| 2018-01-15 15:58 | Christian Grothoff | Target Version | 0.5 => 0.7.1 |
| 2018-01-15 15:58 | Christian Grothoff | Note Added: 0012789 | |
| 2018-09-21 14:24 | Marcello Stanisci | Note Added: 0013251 | |
| 2018-09-24 18:08 | Marcello Stanisci | Note Edited: 0013251 | |
| 2019-02-18 15:02 | Marcello Stanisci | Note Added: 0013858 | |
| 2019-02-18 20:22 | Marcello Stanisci | Note Added: 0013861 | |
| 2020-04-11 18:55 | Christian Grothoff | Status | feedback => resolved |
| 2020-04-11 18:55 | Christian Grothoff | Resolution | open => fixed |
| 2020-04-11 18:55 | Christian Grothoff | Fixed in Version | => 0.7.1 |
| 2021-08-24 16:23 | Christian Grothoff | Status | resolved => closed |
