View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004533 | Taler | specification | public | 2016-05-25 16:20 | 2024-01-12 14:03 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | ||
| Priority | high | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | 0.0 | ||||
| Target Version | 0.0 | ||||
| Summary | 0004533: /admin/add/incoming 'wire' field underspecified, may need to be split | ||||
| Description | Hi, the field 'wire' required in /admin/add/incomign is said to indicate (in the API) the details of the reserve creator; nonetheless, the bank sends the *exchange*'s wire details in this field. Both cases might make sense since the exchange may be accounted in different banks and, this way, the exchange knows in which bank the wire transfer happens. OTOH, the exchange may also want to know who is creating a reserve (which is not worse privacy-wise since it can get this information by looking at the bank's records.) So what was this field's purpose? -M Re: The bank behavior is then incorrect. We need the details of the sender so we can possibly wire the funds _back_. That's the main purpose. The tricky bit is that 'wire' currently combines two things, namely the UUID for the transaction and the routing information of the reserve creator. Maybe we should separate those two, so that it is clear which part is routing data and which one is to ensure transactions are uniquely identified. | ||||
| Tags | No tags attached. | ||||
|
|
Fixed in 3f46877..c0451f0. This changes the /admin/add/incoming API and will thus break the bank. Should be trivial to fix in the bank => Marcello? |
|
|
fixed in 8702a29. WARNING: if the bank is run locally and it tries to withdraw from some exchange on tripwire, it will fail since the 'sender_wire_details' field will contain a 'bank_uri' field related to the local bank, and the exchange will complain since it does not know your local bank. |
|
|
Fix committed to master branch. |
|
exchange: master c0451f09 2016-05-26 18:38 Details Diff |
fix 0004533 for exchange (breaks interaction with bank for /admin/add/incoming) |
Affected Issues 0004533 |
|
| mod - doc/taler-exchange-reservemod.1 | Diff File | ||
| mod - src/exchange-lib/exchange_api_admin.c | Diff File | ||
| mod - src/exchange-lib/exchange_api_reserve.c | Diff File | ||
| mod - src/exchange-lib/test_exchange_api.c | Diff File | ||
| mod - src/exchange-tools/taler-exchange-reservemod.c | Diff File | ||
| mod - src/exchange/taler-exchange-httpd_admin.c | Diff File | ||
| mod - src/exchange/taler-exchange-httpd_db.c | Diff File | ||
| mod - src/exchange/taler-exchange-httpd_db.h | Diff File | ||
| mod - src/exchange/taler-exchange-httpd_deposit.c | Diff File | ||
| mod - src/exchange/taler-exchange-httpd_responses.c | Diff File | ||
| mod - src/exchange/test_taler_exchange_aggregator.c | Diff File | ||
| mod - src/exchangedb/perf_taler_exchangedb_init.c | Diff File | ||
| mod - src/exchangedb/perf_taler_exchangedb_interpreter.c | Diff File | ||
| mod - src/exchangedb/plugin_exchangedb_common.c | Diff File | ||
| mod - src/exchangedb/plugin_exchangedb_postgres.c | Diff File | ||
| mod - src/exchangedb/test_exchangedb.c | Diff File | ||
| mod - src/include/taler_exchange_service.h | Diff File | ||
| mod - src/include/taler_exchangedb_plugin.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-05-25 16:20 | Christian Grothoff | New Issue | |
| 2016-05-25 16:20 | Christian Grothoff | Status | new => assigned |
| 2016-05-25 16:20 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2016-05-26 16:39 | Christian Grothoff | Note Added: 0010770 | |
| 2016-05-26 16:39 | Christian Grothoff | Assigned To | Christian Grothoff => Marcello Stanisci |
| 2016-05-31 01:17 | Christian Grothoff | Target Version | 0.1 => 0.0 |
| 2016-05-31 15:06 | Marcello Stanisci | Note Added: 0010814 | |
| 2016-05-31 15:06 | Marcello Stanisci | Status | assigned => resolved |
| 2016-05-31 15:06 | Marcello Stanisci | Resolution | open => fixed |
| 2016-05-31 15:24 | Christian Grothoff | Status | resolved => closed |
| 2021-09-02 18:13 | Christian Grothoff | Changeset attached | => Taler-exchange master c0451f09 |
| 2021-09-02 18:14 | Christian Grothoff | Note Added: 0018308 | |
| 2021-09-02 18:14 | Christian Grothoff | Assigned To | Marcello Stanisci => Christian Grothoff |
| 2024-01-12 14:03 | Christian Grothoff | Category | exchange API (HTTP specification) => specification |
