View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004519 | Taler | mechant backend | public | 2016-05-23 07:59 | 2024-01-12 14:04 |
| Reporter | Christian Grothoff | Assigned To | Christian Grothoff | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004519: bookmarking does not work | ||||
| Description | When I got to the blog, buy an article, leave the page, clear the cookies and go back to the article, I'm asked to pay again. The expected behavior is that the wallet receives a contract, detects that it is equivalent to an existing contract, replays the old payment and receives access to the content without the user even noticing all that, and certainly without the user paying again. This does work if I go via the history, but not if I just re-visit the page after clearing cookies. This process should also be added to the selenium tests. | ||||
| Steps To Reproduce | go to blog buy article leave page clear cookies return to purchased page | ||||
| Additional Information | I don't know if it is the merchant (bad contract UUID) or the wallet (fails to check for existing contract) that is to blame here. | ||||
| Tags | No tags attached. | ||||
| related to | 0004523 | closed | Marcello Stanisci | selenium test should check if bookmarking works |
|
|
ERROR:talerfrontends.helpers:failed to POST to 'https://shop.test.taler.net/backend/contract' Traceback (most recent call last): File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1836, in __call__ return self.wsgi_app(environ, start_response) File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1820, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1403, in handle_exception reraise(exc_type, exc_value, tb) File "/home/test-green/local/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise raise value File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1817, in wsgi_app response = self.full_dispatch_request() File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1477, in full_dispatch_request rv = self.handle_user_exception(e) File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1381, in handle_user_exception reraise(exc_type, exc_value, tb) File "/home/test-green/local/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise raise value File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1475, in full_dispatch_request rv = self.dispatch_request() File "/home/test-green/local/lib/python3.5/site-packages/flask/app.py", line 1461, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/home/test-green/local/lib/python3.5/site-packages/talerfrontends/blog/blog.py", line 136, in article contract_resp = sign_contract(restored_contract) File "/home/test-green/local/lib/python3.5/site-packages/talerfrontends/helpers.py", line 88, in sign_contract raise BackendError(r.status_code, r.text) talerfrontends.helpers.BackendError: (403, 'Duplicate transaction ID!') |
|
|
Christian, this is caused by this commit in the backend: commit d7eb23ad965c0207e561261588cbf742f93df935 Author: Christian Grothoff <christian@grothoff.org> Date: Thu May 5 13:47:17 2016 +0200 check for duplicate transaction ID |
|
|
I think that the check introduced in that commit is bogus/unnecessary, since we're using /contract also for contract restoration. |
|
|
Ok, then please undo it -- but also extend the test driver to cover this execution path. |
|
|
Fixed in 3e8a86d, selenium coverage is tracked in the related bug. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-05-23 07:59 | Christian Grothoff | New Issue | |
| 2016-05-23 07:59 | Christian Grothoff | Status | new => assigned |
| 2016-05-23 07:59 | Christian Grothoff | Assigned To | => Marcello Stanisci |
| 2016-05-23 14:37 | Florian Dold | Note Added: 0010707 | |
| 2016-05-23 14:41 | Florian Dold | Note Added: 0010708 | |
| 2016-05-23 14:45 | Florian Dold | Note Added: 0010709 | |
| 2016-05-23 14:46 | Florian Dold | Assigned To | Marcello Stanisci => Christian Grothoff |
| 2016-05-23 14:46 | Florian Dold | Status | assigned => feedback |
| 2016-05-23 14:49 | Florian Dold | Relationship added | related to 0004523 |
| 2016-05-23 17:53 | Florian Dold | Category | Web site(s) => merchant backend API (C) |
| 2016-05-23 23:20 | Christian Grothoff | Note Added: 0010714 | |
| 2016-05-23 23:20 | Christian Grothoff | Status | feedback => assigned |
| 2016-05-24 01:22 | Florian Dold | Note Added: 0010721 | |
| 2016-05-24 01:22 | Florian Dold | Status | assigned => resolved |
| 2016-05-24 01:22 | Florian Dold | Resolution | open => fixed |
| 2016-05-24 20:51 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2016-05-24 20:51 | Christian Grothoff | Target Version | 0.1 => 0.0 |
| 2016-05-26 14:26 | Christian Grothoff | Status | resolved => closed |
| 2024-01-12 14:04 | Christian Grothoff | Category | merchant backend API (C) => mechant backend |
