View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003624 | Taler | exchange | public | 2015-01-28 14:42 | 2024-01-12 14:09 |
| Reporter | Christian Grothoff | Assigned To | Sree Harsha Totakura | ||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0003624: need a routine to check JSON format for wire deposits (SEPA specification) | ||||
| Description | Currently, the /deposit handler doesn't check if the JSON 'wire' element is well-formed. We need a generic routine that is extensible for future supported wire formats (i.e. accepting those enabled by the configuration), and a specific routine that checks for correct SEPA details. | ||||
| Tags | No tags attached. | ||||
|
|
fix committed to git master |
|
|
I'm not sure we want to have the execution date in this at all, and AFAIK beneficiary name and BIC are technically also optional with SEPA. Finally, the way this was implemented isn't really pluggable -- the existing code doesn't have any extension mechanism, not even a simple looking up the validator based on the transaction-type logic. Ultimately, we want something where either at compile-time or run-time I can select one or more validation functions. So while this is a good first step towards SEPA-validation, it doesn't quite 'close' the bug. |
|
|
I didn't understand the requirement for this being pluggable/extensible. Why do we need a transaction-type logic for the validation function? Also, run-time selection of this validation function is appropriate at places where it is used, i.e. in the mint; what should be changed with respect to this in the validation function? |
|
|
The Mint should eventually support non-SEPA transactions, like ACH (US). Thus, there must be a natural way to add validators for other transaction standards. Which transaction types are supported by a given mint should be configurable by the operator. Does that clarify? |
|
|
5e8f95c..68774b2 makes it easier (but not yet fully pluggable, which may be overkill) to add additional validators. |
|
|
Added configuration option for wireformat in 68774b2..15bec8f. |
|
|
Fix committed to master branch. |
|
exchange: master bea425de 2015-02-17 18:23 Details Diff |
Fix 0003624: Check JSON format for wire deposits (SEPA specification) |
Affected Issues 0003624 |
|
| mod - src/include/taler_json_lib.h | Diff File | ||
| mod - src/util/Makefile.am | Diff File | ||
| mod - src/util/json.c | Diff File | ||
| add - src/util/test_json_validations.c | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-01-28 14:42 | Christian Grothoff | New Issue | |
| 2015-01-28 16:32 | Sree Harsha Totakura | Assigned To | => Sree Harsha Totakura |
| 2015-01-28 16:32 | Sree Harsha Totakura | Status | new => assigned |
| 2015-02-17 17:35 | Sree Harsha Totakura | Note Added: 0008881 | |
| 2015-02-17 17:35 | Sree Harsha Totakura | Status | assigned => closed |
| 2015-02-17 17:35 | Sree Harsha Totakura | Resolution | open => fixed |
| 2015-02-17 19:43 | Christian Grothoff | Note Added: 0008885 | |
| 2015-02-17 19:43 | Christian Grothoff | Status | closed => feedback |
| 2015-02-17 19:43 | Christian Grothoff | Resolution | fixed => reopened |
| 2015-02-19 16:41 | Sree Harsha Totakura | Note Added: 0008898 | |
| 2015-02-20 16:39 | Christian Grothoff | Note Added: 0008899 | |
| 2015-02-20 16:39 | Christian Grothoff | Status | feedback => assigned |
| 2015-03-24 17:27 | Christian Grothoff | Severity | block => tweak |
| 2015-03-28 14:48 | Christian Grothoff | Target Version | => 0.0 |
| 2015-04-11 16:39 | Christian Grothoff | Assigned To | Sree Harsha Totakura => Christian Grothoff |
| 2015-04-12 22:49 | Christian Grothoff | Note Added: 0009080 | |
| 2015-04-12 22:53 | Christian Grothoff | Note Added: 0009081 | |
| 2015-04-12 22:53 | Christian Grothoff | Status | assigned => resolved |
| 2015-04-12 22:53 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2015-04-12 22:53 | Christian Grothoff | Resolution | reopened => fixed |
| 2015-04-12 23:43 | Christian Grothoff | Status | resolved => closed |
| 2015-11-29 13:54 | Christian Grothoff | Category | util => libtalerutil |
| 2021-09-02 18:14 | Sree Harsha Totakura | Changeset attached | => Taler-exchange master bea425de |
| 2021-09-02 18:14 | Sree Harsha Totakura | Note Added: 0018341 | |
| 2021-09-02 18:14 | Sree Harsha Totakura | Assigned To | Christian Grothoff => Sree Harsha Totakura |
| 2024-01-12 14:09 | Christian Grothoff | Category | libtalerutil => exchange |
