View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003426 | GNUnet | obsolete | public | 2014-06-04 17:04 | 2024-05-03 13:48 |
| Reporter | Christian Grothoff | Assigned To | Matthias Wachs | ||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.11.0pre66 | ||||
| Summary | 0003426: ats-32362 ERROR Assertion failed at plugin_ats_proportional.c:668. | ||||
| Description | Just got this, peer was running in the background. | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0003442 | closed | Matthias Wachs | Revision 33610: To have 6 active addresses looks a little bit weird. |
| has duplicate | 0003432 | closed | Matthias Wachs | ats-19434 ERROR, Revision 33549 |
|
|
Extended with additional information, now looks like: Jun 09 09:35:38-402993 ats-proportional-12734 WARNING WAN: Counted 3 active addresses, but network says to have 15 active addresses Jun 09 09:35:38-403352 ats-proportional-12734 WARNING Active: `T0NG' `udp' length 10 Jun 09 09:35:38-403706 ats-proportional-12734 WARNING Active: `SAJL' `udp' length 10 Jun 09 09:35:38-404058 ats-proportional-12734 WARNING Active: `PD67' `udp' length 10 Jun 09 09:35:38-654345 ats-12734 ERROR Assertion failed at plugin_ats_proportional.c:670. |
|
|
Ok, but that can clearly happen simply because there are not enough peers, right? Also, I think it is legal for there to be MORE than the number of requested connections. Assuming I'm right, I'm changing the log-level to INFO if we have _more_ than desired, and removing the "break" as this is not a logic error => SVN 33649. Please resolve if you agree. |
|
|
No ... there is a inconsistency in the proportional solver with counting addresses in the network: The solver maintains a counter of active addresses and with this assertion the counter and the number of addresses counted while iterating over the list and the value of the counter are different. At some place the number of active addresses is not correctly decreased... |
|
|
Ok, reverted SVN 33649 in SVN 33654. |
|
|
When an outbound connection was disconnected by the destination (due to) shutdown and the session was deleted, ATS_addresses messed up the address' active setting by deactivating an address suggested as an alternative. Therefore proportional activated the address double and therefore counted it double -> proportionals counting was messed up Fixed with revision 33870. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-06-04 17:04 | Christian Grothoff | New Issue | |
| 2014-06-04 17:04 | Christian Grothoff | Status | new => assigned |
| 2014-06-04 17:04 | Christian Grothoff | Assigned To | => Matthias Wachs |
| 2014-06-08 14:11 | Christian Grothoff | Target Version | => 0.11.0pre66 |
| 2014-06-10 09:32 | Matthias Wachs | Note Added: 0008423 | |
| 2014-06-10 09:32 | Matthias Wachs | Relationship added | has duplicate 0003442 |
| 2014-06-11 12:53 | Christian Grothoff | Note Added: 0008427 | |
| 2014-06-12 09:37 | Matthias Wachs | Note Added: 0008428 | |
| 2014-06-12 17:21 | Christian Grothoff | Note Added: 0008429 | |
| 2014-06-26 16:44 | Matthias Wachs | Note Added: 0008470 | |
| 2014-06-26 16:44 | Matthias Wachs | Status | assigned => resolved |
| 2014-06-26 16:44 | Matthias Wachs | Resolution | open => fixed |
| 2014-06-26 16:45 | Matthias Wachs | Relationship added | has duplicate 0003432 |
| 2018-06-07 00:25 | Christian Grothoff | Status | resolved => closed |
| 2024-05-03 13:48 | Christian Grothoff | Category | ATS service => obsolete |
