View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002968 | libmicrohttpd | other | public | 2013-07-24 03:31 | 2021-09-02 17:54 |
| Reporter | blueness | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | All | OS | All | OS Version | All |
| Product Version | 0.9.28 | ||||
| Target Version | 0.9.29 | Fixed in Version | 0.9.29 | ||
| Summary | 0002968: libmicrohttpd-0.9.28: fails to build when ./configure --disable-messages | ||||
| Description | When libmicrohttpd-0.9.28 (latest release as of today) is configured wit messages disable, the build fails with: libtool: link: gcc -DDATA_DIR=\"../../src/datadir/\" -fno-strict-aliasing -g -O2 -o .libs/spdy_event_loop spdy_event_loop.o ../../src/microspdy/.libs/libmicrospdy.so -lssl -lcrypto -lz -ldl -lrt -lpthread ../../src/microhttpd/.libs/libmicrohttpd.so: undefined reference to `MHD_DLOG' collect2: error: ld returned 1 exit status make[4]: *** [minimal_example_comet] Error 1 ../../src/microhttpd/.libs/libmicrohttpd.so: undefined reference to `MHD_DLOG' collect2: error: ld returned 1 exit status make[4]: *** [fileserver_example_external_select] Error 1 ../../src/microhttpd/.libs/libmicrohttpd.so: undefined reference to `MHD_DLOG' collect2: error: ld returned 1 exit status make[4]: *** [fileserver_example_dirs] Error 1 ../../src/microhttpd/.libs/libmicrohttpd.so: undefined reference to `MHD_DLOG' collect2: error: ld returned 1 exit status make[4]: *** [minimal_example] Error 1 ../../src/microhttpd/.libs/libmicrohttpd.so: undefined reference to `MHD_DLOG' collect2: error: ld returned 1 exit status make[4]: *** [refuse_post_example] Error 1 make[4]: Leaving directory `/var/tmp/portage/net-libs/libmicrohttpd-0.9.28/work/libmicrohttpd-0.9.28/src/examples' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/var/tmp/portage/net-libs/libmicrohttpd-0.9.28/work/libmicrohttpd-0.9.28/src/examples' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/var/tmp/portage/net-libs/libmicrohttpd-0.9.28/work/libmicrohttpd-0.9.28/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/var/tmp/portage/net-libs/libmicrohttpd-0.9.28/work/libmicrohttpd-0.9.28' make: *** [all] Error 2 This is because of a missing #if HAVE_MESSAGES in src/microhttpd/daemon.c | ||||
| Steps To Reproduce | 1. ./configure --disable-messages 2. make 3. boom! | ||||
| Tags | No tags attached. | ||||
| Attached Files | libmicrohttpd-0.9.28-fix-no-messages.patch (666 bytes)
diff -Naur libmicrohttpd-0.9.28.orig/src/microhttpd/daemon.c libmicrohttpd-0.9.28/src/microhttpd/daemon.c
--- libmicrohttpd-0.9.28.orig/src/microhttpd/daemon.c 2013-07-23 21:10:14.000000000 -0400
+++ libmicrohttpd-0.9.28/src/microhttpd/daemon.c 2013-07-23 21:11:32.000000000 -0400
@@ -3112,9 +3112,11 @@
int sk_flags = fcntl (socket_fd, F_GETFL);
if (0 != fcntl (socket_fd, F_SETFL, sk_flags | O_NONBLOCK))
{
+#if HAVE_MESSAGES
MHD_DLOG (daemon,
"Failed to make listen socket non-blocking: %s\n",
STRERROR (errno));
+#endif
if (0 != CLOSE (socket_fd))
MHD_PANIC ("close failed\n");
goto free_and_fail;
| ||||
|
|
This patch adds the missing #if HAVE_MESSAGES ... #endif |
|
|
Fixed as suggested in SVN 28330. |
|
|
Fix committed to master branch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-07-24 03:31 | blueness | New Issue | |
| 2013-07-24 03:33 | blueness | Note Added: 0007292 | |
| 2013-07-24 03:33 | blueness | File Added: libmicrohttpd-0.9.28-fix-no-messages.patch | |
| 2013-07-28 16:42 | Christian Grothoff | Note Added: 0007296 | |
| 2013-07-28 16:42 | Christian Grothoff | Status | new => resolved |
| 2013-07-28 16:42 | Christian Grothoff | Fixed in Version | => 0.9.29 |
| 2013-07-28 16:42 | Christian Grothoff | Resolution | open => fixed |
| 2013-07-28 16:42 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2013-07-28 16:42 | Christian Grothoff | Product Version | => 0.9.28 |
| 2013-07-28 16:42 | Christian Grothoff | Target Version | => 0.9.29 |
| 2013-08-23 14:33 | Christian Grothoff | Status | resolved => closed |
| 2021-09-02 17:54 | Christian Grothoff | Changeset attached | => libmicrohttpd master 7056c9e8 |
| 2021-09-02 17:54 | Christian Grothoff | Note Added: 0018210 |
