View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002483 | GNUnet | transport service | public | 2012-07-05 11:12 | 2012-11-05 18:34 |
| Reporter | Matthias Wachs | Assigned To | Matthias Wachs | ||
| Priority | urgent | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.4 | ||||
| Summary | 0002483: Protocol incompatability due to bug 0002480 and 0002481 | ||||
| Description | Bugs 0002480 and 0002481 could cause protocol incompatabilities: - Different format in validation PING messages - Different data used to create PONG Signature In PING Message [HELLO][PING MESSAGE][transport name][address_data] Before 0002841 (bug): char * address_data[address->address_len] = (struct HELLO_Address *) address After 0002841 (correct): char * address_data[address->address_len] = (struct HELLO_Address *) address->address For PONG signature: Before 0002841 (bug): (struct HELLO_Address *) address[address->address_len] After 0002841 (correct): (struct HELLO_Address *) address->address[address->address_len] I have to figure out how peers with the bugs fixed and not fixed behave when communicating. Just replying with a PONG when receiving a PING is not possible since the address to validate is included in the PONG signature. | ||||
| Tags | No tags attached. | ||||
|
|
Test setup: - 2 not nat'ed peers svn head: integration-tests/confs/c_no_nat_client_2.conf 131.159.20.52:20046 (called NBP) rev 22471: integration-tests/confs/c_no_nat_client.conf 131.159.20.52:20028 (called BP) - NBP bootstrapping server, BP client - Peers did connect - NBP printed 1 error message (per validation attempt): Not confirming PING with address `78.77.244.242:40210' since I cannot confirm having this address -> here we can see the buggy IP Address, because it should be (131.159.20.52:20028) NBP has validated address for BP BP has no validated address for NBP Connection from NBP to BP |
|
|
- 1 not nat'ed peers, 1 nat'ed peer svn head: integration-tests/confs/c_no_nat_client.conf 131.159.20.52:20028 (called NBP) rev 22471: integration-tests/confs/c_nat_client.conf 131.159.20.52:0 (called BP) - took hello from NBP -> BP: Peers do not connect BP cannot NBP address BP sends PING to NBP, NBP does not respond |
|
|
- 1 not nat'ed peers, 1 nat'ed peer svn head: integration-tests/confs/c_nat_client.conf 131.159.20.52:0 (called NBP) rev 22471: integration-tests/confs/c_no_nat_client.conf 131.159.20.52:20028 (called BP) - took hello from BP -> NBP: Peers do connect and NBP validates address |
|
|
Added code to keep compatibility in 22503. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-05 11:12 | Matthias Wachs | New Issue | |
| 2012-07-05 11:12 | Matthias Wachs | Status | new => assigned |
| 2012-07-05 11:12 | Matthias Wachs | Assigned To | => Matthias Wachs |
| 2012-07-05 11:14 | Matthias Wachs | Description Updated | |
| 2012-07-05 11:16 | Matthias Wachs | Description Updated | |
| 2012-07-05 11:18 | Matthias Wachs | Description Updated | |
| 2012-07-05 12:03 | Matthias Wachs | Note Added: 0006209 | |
| 2012-07-05 12:04 | Matthias Wachs | Note Edited: 0006209 | |
| 2012-07-05 13:08 | Matthias Wachs | Note Added: 0006210 | |
| 2012-07-05 13:29 | Matthias Wachs | Note Edited: 0006210 | |
| 2012-07-05 14:01 | Matthias Wachs | Note Edited: 0006209 | |
| 2012-07-05 14:03 | Matthias Wachs | Note Edited: 0006209 | |
| 2012-07-05 14:14 | Matthias Wachs | Note Edited: 0006210 | |
| 2012-07-05 14:19 | Matthias Wachs | Note Added: 0006213 | |
| 2012-07-05 17:39 | Matthias Wachs | Note Added: 0006214 | |
| 2012-07-05 17:39 | Matthias Wachs | Status | assigned => resolved |
| 2012-07-05 17:39 | Matthias Wachs | Resolution | open => fixed |
| 2012-11-05 18:34 | Christian Grothoff | Status | resolved => closed |
