0002480: GNUNET_HELLO_address_cmp does not compare correctly

ID	Project	Category	View Status	Date Submitted	Last Update

0002480	GNUnet	hello library	public	2012-07-04 11:28	2012-11-05 18:34

Reporter	Matthias Wachs	Assigned To	Matthias Wachs
Priority	immediate	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Git master
Target Version	0.9.4

Summary	0002480: GNUNET_HELLO_address_cmp does not compare correctly
Description	gnunet-service-transport_validation: validation_entry_match (void cls, const struct GNUNET_HashCode key, void value) { struct ValidationEntryMatchContext vemc = cls; struct ValidationEntry ve = value; if (0 == GNUNET_HELLO_address_cmp (ve->address, vemc->address)) { char ve_addr = strdup (GST_plugins_a2s(ve->address)); GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Addresses are equal: `%s' address `%s' == `%s'\n", GNUNET_i2s (&ve->address->peer), ve_addr, GST_plugins_a2s(vemc->address)); GNUNET_free (ve_addr); vemc->ve = ve; return GNUNET_NO; } return GNUNET_YES; } Result: Jul 04 11:26:03-192278 transport-5155 ERROR Addresses are equal: `9P6V' address `13:22:33:44:A9:67' == `4E:4D:F4:F2:9D:12'
Tags	No tags attached.

Date Modified	Username	Field	Change
2012-07-04 11:28	Matthias Wachs	New Issue
2012-07-04 11:28	Matthias Wachs	Status	new => assigned
2012-07-04 11:28	Matthias Wachs	Assigned To	=> Matthias Wachs
2012-07-04 11:31	Matthias Wachs	Relationship added	related to 0002472
2012-07-04 11:37	Matthias Wachs	Note Added: 0006206
2012-07-04 11:38	Matthias Wachs	Status	assigned => resolved
2012-07-04 11:38	Matthias Wachs	Resolution	open => fixed
2012-07-04 11:38	Matthias Wachs	Target Version	=> 0.9.4
2012-11-05 18:34	Christian Grothoff	Status	resolved => closed

Matthias Wachs 2012-07-04 11:37 reporter ~0006206	If address length for both addresses were equal, it did that: return memcmp (a1->address, a1->address, a1->address_length); obvious... fixed in 22472.