View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002476 | GNUnet | testing library | public | 2012-07-02 16:33 | 2012-11-05 18:34 |
| Reporter | Matthias Wachs | Assigned To | Sree Harsha Totakura | ||
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0002476: GNUNET_TESTING_configuration_create sets ACCEPT_FROM to "127.0.0.1;" for transport plugins | ||||
| Description | update_config_sections sets ACCEPT_FROM by default to "127.0.0.1;" if no other value is given. This breaks tcp plugin, since the tcp plugin needs to accept connections from anywhere This especially breaks tcp_nat tests Please think about the possibilites: - set default to "global" - skip transport plugins | ||||
| Tags | No tags attached. | ||||
|
|
mwachs hacked up a version to 'skip' transport plugins. That works, not sure if it is the cleanest version I can think of... I think it would be better if, by default (TRUSTED option not given/NULL), we should simply NOT set the option and stick to defaults -- which restrict to loopback for services and are unrestricted for transport plugins. |
|
|
fixed it by introducing a new testing-specific option TESTING_IGNORE_KEYS. This option takes multiple keys separated by ';' as value. e.g: [transport-tcp] TESTING_IGNORE_KEYS = ACCEPT_FROM;PORT;ADVERTISED_PORT; The testing library checks this value for keys to ignore. For now, it has been programmed not to modify ACCEPT_FROM in a section if the section has ACCEPT_FROM present in its TESTING_IGNORE_KEYS option. |
|
|
Hmmm I read the solution https://gnunet.org/bugs/view.php?id=2476#c6194 I don't know if I like the solution that the [transport-*] section contain settings for the testing lib. Is it perhaps better to include an option in the [testing] section which config sections should not be modified like: SKIPSECTIONS = transport-* But then we have to add every new plugin... If we have an option which section should be explicitly modified we have to add each new service ... MODIFYSECTIONS = arm,core,dht, ... newservice Just my few cents... |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-02 16:33 | Matthias Wachs | New Issue | |
| 2012-07-02 16:33 | Matthias Wachs | Status | new => assigned |
| 2012-07-02 16:33 | Matthias Wachs | Assigned To | => Sree Harsha Totakura |
| 2012-07-02 16:33 | Matthias Wachs | Severity | minor => major |
| 2012-07-02 16:33 | Matthias Wachs | Product Version | => Git master |
| 2012-07-02 19:11 | Christian Grothoff | Note Added: 0006190 | |
| 2012-07-02 23:50 | Sree Harsha Totakura | Note Added: 0006194 | |
| 2012-07-02 23:50 | Sree Harsha Totakura | Status | assigned => resolved |
| 2012-07-02 23:50 | Sree Harsha Totakura | Fixed in Version | => 0.9.4 |
| 2012-07-02 23:50 | Sree Harsha Totakura | Resolution | open => fixed |
| 2012-07-03 10:28 | Matthias Wachs | Note Added: 0006195 | |
| 2012-07-04 19:55 | Christian Grothoff | Target Version | => 0.9.4 |
| 2012-11-05 18:34 | Christian Grothoff | Status | resolved => closed |
