View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002229 | GNUnet | file-sharing service | public | 2012-03-20 02:10 | 2012-06-02 19:15 |
| Reporter | LRN | Assigned To | Christian Grothoff | ||
| Priority | high | Severity | crash | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0002229: fip_signal_start() relies on metadata to detect directories | ||||
| Description | fip_signal_start() calls GNUNET_FS_meta_data_test_for_directory() on the metadata to detect that it's dealing with a directory and recourse into it. However, GNUnet-FS-GTK allows the user to remove metadata - including the directory mime type, which prevents fip_signal_start() from working correctly, and leads to eventual segfault. I propose to not to rely on GNUNET_FS_meta_data_test_for_directory() here, and use some other way to detect directories. | ||||
| Tags | No tags attached. | ||||
|
|
Well, we used to take the meta data only as "advice" and if it was absent would simply 'try' if the file was a directory anyway later. Also, for directories, the filename is 'supposed' to end with "/". Now, the real issue here clearly is the crash -- nothing can stop the publisher from not putting the "/" or putting the wrong mime type (and I think it is fine if the receiver then doesn't treat the file as a directory). Can you provide a more detailed crash report? |
|
|
I could not reproduce the crash. However, I removed the call to test for directory-status to fs meta data in SVN 21167, so the underlying cause (if diagnosed correctly) should definitively be gone now. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-03-20 02:10 | LRN | New Issue | |
| 2012-03-20 09:36 | Christian Grothoff | Note Added: 0005645 | |
| 2012-03-20 09:37 | Christian Grothoff | Priority | low => high |
| 2012-03-20 09:37 | Christian Grothoff | Severity | tweak => crash |
| 2012-03-20 09:37 | Christian Grothoff | Product Version | => Git master |
| 2012-03-20 09:37 | Christian Grothoff | Target Version | => 0.9.3 |
| 2012-03-20 09:37 | Christian Grothoff | Status | new => feedback |
| 2012-04-26 13:35 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2012-04-26 13:35 | Christian Grothoff | Status | feedback => assigned |
| 2012-04-26 13:36 | Christian Grothoff | Note Added: 0005745 | |
| 2012-04-26 13:36 | Christian Grothoff | Status | assigned => resolved |
| 2012-04-26 13:36 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2012-04-26 13:36 | Christian Grothoff | Resolution | open => fixed |
| 2012-06-02 19:15 | Christian Grothoff | Status | resolved => closed |
