View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002080 | gnunet-gtk | gnunet-fs-gtk | public | 2012-01-17 17:35 | 2012-02-28 11:06 |
| Reporter | LRN | Assigned To | Christian Grothoff | ||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.2 | Fixed in Version | 0.9.2 | ||
| Summary | 0002080: Improper tree representation when doing recursive download of complex directories | ||||
| Description | The tree displayed in orphans tab (why there, if we still have the initial directory search result on a search tab?) is disjoined. | ||||
| Steps To Reproduce | 1) Search for "share" 2) Download the directory you find recursively (save as "share.gnd"). Results: In search tab "share" gets a name - "share.gnd", with absolute directory name, progress=100. However, rightclicking on it brings the menu with "Abort download", and it won't be cleaned by the "Cleanup" button In orphans tab a number of entries is added, some are for files, other are for .gnd files (directories). They do not form a hierarchy. For example, if we have this tree: dir1/ -dir2/ --dir21/ ---file211 --dir22/ ---file221 --file21 --file22 -dir3/ -dir4/ --file41 -file1 -file2 Then the orphans tab will contain, if we download to c:\foobar\ c:\foobar\dir2.gnd (green) -dir21 (white) -dir22 (white) c:\foobar\dir3.gnd (green) c:\foobar\dir4.gnd (green) -file41 (white) c:\foobar\dir21.gnd (green) -file211 (white) c:\foobar\dir22.gnd (green) -file221 (white) c:\foobar\file1 (green) c:\foobar\file2 (green) c:\foobar\file41 (green) c:\foobar\file211 (green) c:\foobar\file221 (green) in seemingly random order (dir1.gnd will remain in search tab, unexpanded) (white and green refer to the color of the entry; white ones stay at 0%) | ||||
| Tags | No tags attached. | ||||
| related to | 0002137 | closed | Christian Grothoff | "clean" button in URI-tab only cleans one result at a time |
|
|
LRN, didn't one of your recent patches fix this one? |
|
|
No, i've never addressed this particular issue. |
|
|
Ok, when I do this, I see two things: 1) the downloaded files on disk DO have the proper hierarchy 2) the GtkTreeView shows the results as a FLAT result list (no hierarchy), and instead of putting them under the search result, they appear in the URI-tab instead immediately; only the top-level results *also* appear in under the search result (but there without the "completed" attribution) 3) I got a crash when I then clicked on the "clean" button in the URI tab a few times |
|
|
My interpretation so far: maybe in recursive-download, libgnunetfs doesn't cleanly initialize the parent links (especially maybe if the directory contains the results as embedded data), which then causes downloads to be started from "nowhere". Not sure about the crash yet. |
|
|
libgnunetfs was not too blame, gnunet-fs-gtk simply added the entries in directories too late: upon completed, instead upon progress with completed==size. This way (under certain circumstances), we'd get a child download started before the parent had the entry setup. Fixed in SVN 19693. However, the "clean" crash is still there. |
|
|
Should be fixed in SVN 19697. (need to test) |
|
|
Works fine in 19700. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-01-17 17:35 | LRN | New Issue | |
| 2012-01-17 19:54 | Christian Grothoff | Priority | low => high |
| 2012-01-17 19:54 | Christian Grothoff | Severity | trivial => major |
| 2012-01-17 19:54 | Christian Grothoff | Status | new => acknowledged |
| 2012-01-17 19:54 | Christian Grothoff | Target Version | => 0.9.2 |
| 2012-01-18 20:32 | Christian Grothoff | Note Added: 0005287 | |
| 2012-01-18 21:02 | LRN | Note Added: 0005288 | |
| 2012-01-31 13:10 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2012-01-31 13:10 | Christian Grothoff | Status | acknowledged => assigned |
| 2012-02-04 22:25 | Christian Grothoff | Note Added: 0005425 | |
| 2012-02-04 22:26 | Christian Grothoff | Note Added: 0005426 | |
| 2012-02-04 23:27 | Christian Grothoff | Note Added: 0005427 | |
| 2012-02-04 23:28 | Christian Grothoff | Relationship added | related to 0002137 |
| 2012-02-05 14:29 | Christian Grothoff | Note Added: 0005432 | |
| 2012-02-05 17:06 | Christian Grothoff | Note Added: 0005436 | |
| 2012-02-05 17:06 | Christian Grothoff | Status | assigned => resolved |
| 2012-02-05 17:06 | Christian Grothoff | Fixed in Version | => 0.9.2 |
| 2012-02-05 17:06 | Christian Grothoff | Resolution | open => fixed |
| 2012-02-28 11:06 | Christian Grothoff | Status | resolved => closed |
