View Issue Details

IDProjectCategoryView StatusLast Update
0002045gnunet-gtkgnunet-fs-gtkpublic2012-02-28 11:06
ReporterLRN Assigned ToLRN  
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.9.2Fixed in Version0.9.2 
Summary0002045: [patch] Inadequate keyword (metadata?) propagation
DescriptionWhen there are two entities in a directory (say, one file and one directory), metadata from both of them gets propagated to the parent directory, because it reaches the 50% threshold.
TagsNo tags attached.
Attached Files
0001-Don-t-forward-metadata-from-only-one-file.patch (1,134 bytes)   
From 1321ce7aad8a52a126fe40cfe28a2aab91455ded Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD=20=D0=98=D0=B6=D0=B1=D1?=
 =?UTF-8?q?=83=D0=BB=D0=B0=D1=82=D0=BE=D0=B2?= <lrn1986@gmail.com>
Date: Wed, 28 Dec 2011 23:21:19 +0400
Subject: [PATCH] Don't forward metadata from only one file

---
 src/fs/gnunet-fs-gtk-main_window_file_publish.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/fs/gnunet-fs-gtk-main_window_file_publish.c b/src/fs/gnunet-fs-gtk-main_window_file_publish.c
index 9bda67c..61a1c70 100644
--- a/src/fs/gnunet-fs-gtk-main_window_file_publish.c
+++ b/src/fs/gnunet-fs-gtk-main_window_file_publish.c
@@ -683,7 +683,7 @@ migrate_and_drop (void *cls, const GNUNET_HashCode * key, void *value)
   struct MetaProcessContext *mpc = cls;
   struct MetaCounter *counter = value;
 
-  if (counter->count >= mpc->threshold)
+  if (counter->count >= mpc->threshold && counter->count > 1)
   {
     GNUNET_CONTAINER_meta_data_insert (mpc->md, "<gnunet-gtk>", counter->type,
                                        counter->format, counter->value_mimetype,
-- 
1.7.4

Activities

Christian Grothoff

2011-12-31 00:14

manager   ~0005224

Fixed in SVN 18860.

Issue History

Date Modified Username Field Change
2011-12-28 19:34 LRN New Issue
2011-12-28 20:21 LRN File Added: 0001-Don-t-forward-metadata-from-only-one-file.patch
2011-12-28 20:22 LRN Summary Inadequate keyword (metadata?) propagation => [patch] Inadequate keyword (metadata?) propagation
2011-12-31 00:14 Christian Grothoff Note Added: 0005224
2011-12-31 00:14 Christian Grothoff Status new => resolved
2011-12-31 00:14 Christian Grothoff Fixed in Version => 0.9.2
2011-12-31 00:14 Christian Grothoff Resolution open => fixed
2011-12-31 00:14 Christian Grothoff Assigned To => LRN
2011-12-31 00:14 Christian Grothoff Target Version => 0.9.2
2012-02-28 11:06 Christian Grothoff Status resolved => closed