View Issue Details

IDProjectCategoryView StatusLast Update
0001958GNUnetobsoletepublic2024-05-03 13:51
ReporterLRN Assigned ToLRN  
PriorityurgentSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.9.0Fixed in Version0.9.0 
Summary0001958: New code for GNUNET_OS_network_interfaces_list
Descriptionsubj

Somewhat neater (IMHO) code
Requires XP SP1 or later
Best results with Vista or later (on XP it can't get subnet masks for IPv6)
Better support for IPv6

Lots of new defines in win.cc is due to me being a completionist, we certainly can get away with roughly 2 times less code.
These definitions should have been in MinGW w32api package, but they aren't there, and i loathe to send patches to MinGW team (since MAX_DNS_SUFFIX_STRING_LENGTH value was taken from MS PSDK (everything else is from MSDN or from RFCs), the patch is considered "tainted", and MinGW won't accept it).

I removed EnumNICs, introduced EnumNICs2 and EnumNICs3 and some helper functions. Also fixed up ListNICs (not sure if it is used by anything right now...).

Fixed GGetAdaptersInfo -> GNGetAdaptersInfo (although the function is not used anymore; actually, there are several functions that are not used anymore, but are still imported at library initialization).

The code is somewhat lacking on the documentation side though.

P.S. reading the diff for win.cc is not very useful, since `diff' tried to be too smart for its own good.
TagsNo tags attached.
Attached Files
listnics.tar.xz (8,736 bytes)

Activities

Christian Grothoff

2011-11-29 12:48

manager   ~0004999

Applied as SVN 18370 (all 4 patches).

Issue History

Date Modified Username Field Change
2011-11-23 18:58 LRN New Issue
2011-11-23 18:58 LRN Status new => assigned
2011-11-23 18:58 LRN Assigned To => NDurner
2011-11-23 18:58 LRN File Added: listnics.tar.xz
2011-11-26 09:48 Christian Grothoff Target Version => 0.9.0
2011-11-28 16:25 Christian Grothoff Priority normal => urgent
2011-11-29 12:48 Christian Grothoff Note Added: 0004999
2011-11-29 12:48 Christian Grothoff Status assigned => resolved
2011-11-29 12:48 Christian Grothoff Fixed in Version => 0.9.0
2011-11-29 12:48 Christian Grothoff Resolution open => fixed
2011-11-29 12:48 Christian Grothoff Assigned To NDurner => LRN
2011-11-30 18:38 Christian Grothoff Status resolved => closed
2024-01-12 14:28 schanzen Category Win32 port => Win32 port (deprecated)
2024-05-03 13:51 Christian Grothoff Category Win32 port (deprecated) => obsolete