View Issue Details

IDProjectCategoryView StatusLast Update
0009951Talerqtartpublic2025-06-03 21:14
Reporterfefe Assigned ToFlorian Dold  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Summary0009951: integer overflow in js_talercrypto_hash_argon2id
DescriptionIn tart_module.c:

   518 mem_size * 1024,

mem_size is a uint32, 1024 is an int, so mem_size * 1024 is a uint32. The function expects a size_t, so the truncated result will be promoted to 64-bit.

If mem_size is big enough, an unexpected truncation might happen here (probably not causing too much damage though)
TagsNo tags attached.

Activities

Florian Dold

2025-06-03 21:14

manager   ~0025117

commit a14ef3ecc9b7564bc12245a080e83e4092f6f29e (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Jun 3 21:13:41 2025 +0200

    check for overflow in js_talercrypto_hash_argon2id
    
    Issue: https://bugs.taler.net/n/9951

Issue History

Date Modified Username Field Change
2025-05-13 13:55 fefe New Issue
2025-05-13 14:39 Christian Grothoff Assigned To => Florian Dold
2025-05-13 14:39 Christian Grothoff Status new => assigned
2025-06-03 21:14 Florian Dold Status assigned => resolved
2025-06-03 21:14 Florian Dold Resolution open => fixed
2025-06-03 21:14 Florian Dold Note Added: 0025117