View Issue Details

IDProjectCategoryView StatusLast Update
0009951Talerqtartpublic2025-10-31 19:49
Reporterfefe Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.1Fixed in Version1.1 
Summary0009951: integer overflow in js_talercrypto_hash_argon2id
DescriptionIn tart_module.c:

   518 mem_size * 1024,

mem_size is a uint32, 1024 is an int, so mem_size * 1024 is a uint32. The function expects a size_t, so the truncated result will be promoted to 64-bit.

If mem_size is big enough, an unexpected truncation might happen here (probably not causing too much damage though)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2025-06-03 19:14

manager   ~0025117

commit a14ef3ecc9b7564bc12245a080e83e4092f6f29e (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Tue Jun 3 21:13:41 2025 +0200

    check for overflow in js_talercrypto_hash_argon2id
    
    Issue: https://bugs.taler.net/n/9951

Issue History

Date ModifiedUsernameFieldChange
2025-05-13 11:55fefeNew Issue
2025-05-13 12:39Christian GrothoffAssigned To => Florian Dold
2025-05-13 12:39Christian GrothoffStatusnew => assigned
2025-06-03 19:14Florian DoldStatusassigned => informing
2025-06-03 19:14Florian DoldResolutionopen => fixed
2025-06-03 19:14Florian DoldNote Added: 0025117
2025-10-18 22:51Christian GrothoffFixed in Version => 1.1
2025-10-18 22:51Christian GrothoffTarget Version => 1.1
2025-10-31 19:49Christian GrothoffStatusinforming => closed