View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009677 | Taler | exchange AML backoffice (SPA) | public | 2025-03-30 10:04 | 2025-06-03 22:30 |
| Reporter | Christian Grothoff | Assigned To | sebasjm | ||
| Priority | normal | Severity | tweak | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 1.0 stretch goals | ||||
| Summary | 0009677: force manual AML_INVESTIGATION_STATE on 'other' (est 4h - due date 4/6) | ||||
| Description | When INCRISK_RESULT is set to "other" (vqf 902 14), the AML officer should be forced to manually specify the new INVESTIGATION_STATE account's property (and not default to INVESTIGATION_COMPLETED_WITHOUT_SUSPICION). If we pick a default, it could either be INVESTIGATION_PENDING or the previous state, but I think it would be best to require a manual decision here. | ||||
| Tags | compliance | ||||
| child of | 0008155 | confirmed | acceptance testing of SPA with MG |
|
|
ACK i will implement this as: * if ( 1 and 2 ) 1) the form `vqf 902 14` is being submitted as new attributes of account 2) and the form has INCRISK_RESULT == other * then 1) INVESTIGATION_STATE is required in the decision properties 2) INVESTIGATION_STATE can't have the value INVESTIGATION_COMPLETED_WITHOUT_SUSPICION or NONE (only pending or reported) |
|
|
I'm think we should allow the AML officer to override (which your comment suggests is not allowed); this is really just about generating a sane default when the form is set to OTHER. Also, why would such a simple change take 4h? It would seem trivial for the vqf 902.14 form to have a trigger that, when the respective box is checked, updates the state. I'd estimate this at 5-15 minutes, so either the AML SPA architecture is completely messed up, or you're including time to do some comprehensive automated testing, or I don't know how this takes 4h. |
|
|
> should be forced to manually specify the new INVESTIGATION_STATE account's property I took this as "should be required" and this form doesn't have a validation check to prevent the submission, this is not a simple change in the derivation function. Also a reset button to go back to the normal state after you play around with the form. > I'm think we should allow the AML officer to override (which your comment suggests is not allowed); this is really just about generating a sane default when the form is set to OTHER. Now with this I'm more confused give your comment on the docs > would be nice if we instead could set the property to "undefined"/null and *force* the AML officer to manually set it. That is what I'm aiming for, modifying the behavior of the wizard to prevent the submission of the form if it didn't select in one option on INVESTIGATION_STATE. If changing "INVESTIGATION_COMPLETED_WITHOUT_SUSPICION" to "INVESTIGATION_PENDING" is enough, then yes. Is simpler. > AML SPA architecture is completely messed up Also yes, product of changing a lot of thing on the last minute. Testing is more painful tho. |
|
|
Let's for now just change "INVESTIGATION_COMPLETED_WITHOUT_SUSPICION" to "INVESTIGATION_PENDING". I think in general the rule is that the AML officer can "always" override anything, but the forms should minimize their work and mistakes (like forgetting to set that state). If we want hard invariant checks, that's something else for the future. |
|
|
2908fae4c..f958080a6 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-03-30 10:04 | Christian Grothoff | New Issue | |
| 2025-03-30 10:04 | Christian Grothoff | Status | new => assigned |
| 2025-03-30 10:04 | Christian Grothoff | Assigned To | => sebasjm |
| 2025-04-17 22:12 | Christian Grothoff | Tag Attached: compliance | |
| 2025-04-23 19:13 | sebasjm | Target Version | 1.0 stretch goals => 1.0 |
| 2025-04-24 01:26 | Christian Grothoff | Target Version | 1.0 => 1.0 stretch goals |
| 2025-05-08 22:15 | Christian Grothoff | Relationship added | child of 0008155 |
| 2025-05-14 17:30 | sebasjm | Description Updated | |
| 2025-05-14 17:33 | sebasjm | Note Added: 0024905 | |
| 2025-06-03 17:23 | sebasjm | Summary | force manual AML_INVESTIGATION_STATE on 'other' => force manual AML_INVESTIGATION_STATE on 'other' (est 4h - due date 4/6) |
| 2025-06-03 19:58 | Christian Grothoff | Note Added: 0025109 | |
| 2025-06-03 21:49 | sebasjm | Note Added: 0025118 | |
| 2025-06-03 22:14 | Christian Grothoff | Note Added: 0025119 | |
| 2025-06-03 22:30 | sebasjm | Status | assigned => resolved |
| 2025-06-03 22:30 | sebasjm | Resolution | open => fixed |
| 2025-06-03 22:30 | sebasjm | Note Added: 0025120 |
