View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009630 | Taler | merchant backend | public | 2025-03-18 13:31 | 2025-03-19 01:54 |
| Reporter | fefe | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | trivial | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.0 | Fixed in Version | 1.0 | ||
| Summary | 0009630: confusing if statement in generate_success_response | ||||
| Description | In taler-merchant-httpd_post-orders-ID-abort.c: 380 if (! rdi->found_deposit) 386 else if (MHD_HTTP_OK != rdi->http_status) 404 else if (rdi->found_deposit) The condition in line 404 will always be true, but it makes it look like it might not. That confuses human readers and also the clang-tidy static analyzer which warns that detail may be used uninitialized if this is not taken. | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-03-18 13:31 | fefe | New Issue | |
| 2025-03-18 13:31 | fefe | Status | new => assigned |
| 2025-03-18 13:31 | fefe | Assigned To | => Christian Grothoff |
| 2025-03-19 01:53 | Christian Grothoff | Note Added: 0024239 | |
| 2025-03-19 01:53 | Christian Grothoff | Severity | minor => trivial |
| 2025-03-19 01:53 | Christian Grothoff | Status | assigned => resolved |
| 2025-03-19 01:53 | Christian Grothoff | Product Version | => git (master) |
| 2025-03-19 01:53 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-03-19 01:53 | Christian Grothoff | Target Version | => 1.0 |
| 2025-03-19 01:54 | Christian Grothoff | Changeset attached | => merchant master 70184085 |
| 2025-03-19 01:54 | Christian Grothoff | Note Added: 0024240 | |
| 2025-03-19 01:54 | Christian Grothoff | Resolution | open => fixed |
| 2025-03-22 14:09 | Christian Grothoff | Category | mechant backend => merchant backend |
