View Issue Details

IDProjectCategoryView StatusLast Update
0009494Talerwallet (Android App)public2025-02-14 22:42
ReporterChristian Grothoff Assigned Toavalos  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Versiongit (master) 
Target Version1.0Fixed in Version1.0 
Summary0009494: amount entry dialog for templates hard to read
Descriptionspecifcally, the currency is shown twice, and in the amount entry field for the number NETZBON overlaps with the actual number to be entered without space. It would be better to only show the currency once (on the right of the amount is probably fine).

We should also check on iOS...
Steps To ReproduceSeen with Isidor at Netzbon test.
TagsNo tags attached.

Activities

avalos

2025-01-31 20:55

developer   ~0024028

Locale-dependent amount rendering is currently used in all amount inputs, so the placement of the currency symbol can be either left or right.

Furthermore, some views require a currency selector. If the currency has no symbol or the symbol is the same as the currency string, the same string will appear in both the amount input and the currency selector.

[ NETZBON 1.0 ] [ NETZBON ▾ ]
                                          [ NETZBON ]
                                          [ KUDOS ]
                                          [ CHF ]
                                          [ EUR ]

Christian Grothoff

2025-01-31 22:58

manager   ~0024033

Well, I understand amount-rending is locale dependent and that we sometimes need a currency selector. But, what is probably bad is to (1) have the currency be stated twice, and (2) run out of space because of it, causing Isidor trouble reading the amount next to the currency due to lack of whitespace.

My suggestion: put the currency selector either to the right or to the left of the actual amount, depending on the locale. Do NOT put the currency into the amount editing widget as well, thus:

[NEZTBON ▾ ] 1.0

or

1.0 [NEZTBON ▾ ]

depending on locale (with 1.0 being the editable number).

Sounds good?

Christian Grothoff

2025-01-31 22:58

manager   ~0024034

MarcS: what does iOS do?

avalos

2025-02-04 13:08

developer   ~0024040

> My suggestion: put the currency selector either to the right or to the left of the actual amount, depending on the locale.

AFAIK, I don't get that information from the locale, I only get the final formatted string.

I can do a test formatting and find the positioning manually, but I don't like it :\

I will remove the symbol from the input, but can we just leave it on the right? Besides, the selector contains the currency string (e.g. KUDOS), not the symbol (e.g. ク), so semantically speaking it isn't really meant to be part of the formatted amount, so locale-dependent formatting does not apply.

Christian Grothoff

2025-02-04 17:26

manager   ~0024043

I see. I think the problem is different: for NETZBON, the symbol is the SAME as the currency string, which is probably also why it looks particularly bad. If it is just ク3.45 or 4.5$ it wouldn't be a problem, but putting NETZBON twice in the same line is bad.

So maybe there is an alternative: keep the existing logic, but *if* the symbol and the currency string are *identical*, give an empty string for the symbol to the currency formatter in this specific dialog where the currency string is shown in a box on the right.

Marc: WDYT?

MarcS

2025-02-04 17:28

developer   ~0024044

> *if* the symbol and the currency string are *identical*, give an empty string for the symbol to the currency formatter in this specific dialog where the currency string is shown in a box on the right.

ACK, sounds good...

avalos

2025-02-04 17:30

developer   ~0024045

Yep, sounds good. :)

avalos

2025-02-06 16:02

developer   ~0024056

Fixed in master! :)

commit c9a7c750322c3d4957f05ba6b286681398eb7e48
Author: Iván Ávalos <avalos@disroot.org>
Date: Thu Feb 6 15:56:56 2025 +0100

    [wallet] hide symbol from amount input if it matches currency string
    
    bug 0009494
image.png (63,138 bytes)   
image.png (63,138 bytes)   

Issue History

Date Modified Username Field Change
2025-01-30 19:26 Christian Grothoff New Issue
2025-01-30 19:26 Christian Grothoff Status new => assigned
2025-01-30 19:26 Christian Grothoff Assigned To => avalos
2025-01-31 20:55 avalos Note Added: 0024028
2025-01-31 20:57 avalos Assigned To avalos => Christian Grothoff
2025-01-31 20:57 avalos Status assigned => feedback
2025-01-31 22:58 Christian Grothoff Note Added: 0024033
2025-01-31 22:58 Christian Grothoff Note Added: 0024034
2025-01-31 22:58 Christian Grothoff Assigned To Christian Grothoff => avalos
2025-01-31 22:58 Christian Grothoff Status feedback => assigned
2025-02-04 13:08 avalos Note Added: 0024040
2025-02-04 13:09 avalos Assigned To avalos => Christian Grothoff
2025-02-04 13:09 avalos Status assigned => feedback
2025-02-04 17:26 Christian Grothoff Note Added: 0024043
2025-02-04 17:26 Christian Grothoff Assigned To Christian Grothoff => MarcS
2025-02-04 17:28 MarcS Note Added: 0024044
2025-02-04 17:29 MarcS Assigned To MarcS => avalos
2025-02-04 17:30 avalos Note Added: 0024045
2025-02-06 16:02 avalos Note Added: 0024056
2025-02-06 16:02 avalos File Added: image.png
2025-02-06 16:02 avalos Status feedback => resolved
2025-02-06 16:02 avalos Resolution open => fixed
2025-02-14 22:42 Christian Grothoff Fixed in Version => 1.0