View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009458 | Taler | mechant backend | public | 2025-01-14 15:35 | 2025-01-14 16:18 |
| Reporter | fefe | Assigned To | Christian Grothoff | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 1.0 | ||||
| Summary | 0009458: sign_token_envelopes: off by one? | ||||
| Description | ``` 2566 const struct TokenEnvelope *env = &pc->token_envelopes[pos]; 2567 struct SignedOutputToken *output = &pc->output_tokens[pos]; 2568 2569 if (pos > pc->token_envelopes_cnt || pos > pc->output_tokens_len) 2570 { 2571 GNUNET_assert (0); /* this should not happen */ 2572 return GNUNET_NO; 2573 } ``` Isn't pos already out of bounds if it is == the count? If the count is 3 then the valid indices are 0, 1, 2 ...? | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-01-14 15:35 | fefe | New Issue | |
| 2025-01-14 15:35 | fefe | Status | new => assigned |
| 2025-01-14 15:35 | fefe | Assigned To | => Christian Grothoff |
| 2025-01-14 16:18 | Christian Grothoff | Changeset attached | => merchant master 9c5b4f1d |
| 2025-01-14 16:18 | Christian Grothoff | Note Added: 0023977 | |
| 2025-01-14 16:18 | Christian Grothoff | Status | assigned => resolved |
| 2025-01-14 16:18 | Christian Grothoff | Resolution | open => fixed |
| 2025-01-14 16:18 | Christian Grothoff | Fixed in Version | => 1.0 |
| 2025-01-14 16:18 | Christian Grothoff | Note Added: 0023978 |
