View Issue Details

IDProjectCategoryView StatusLast Update
0009312GNUnetutil librarypublic2024-11-14 09:43
Reporterfefe Assigned Toschanzen  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version0.23.0 
Summary0009312: GNUNET_DISK_internal_file_handle_: why void*?!
DescriptionHere is the prototype of the function:

  1631 enum GNUNET_GenericReturnValue
  1632 GNUNET_DISK_internal_file_handle_ (const struct GNUNET_DISK_FileHandle *fh,
  1633 void *dst,
  1634 size_t dst_len)

why would you have void*?!
You are writing an int. Always. So make it an int* and get rid of the dst_len.
You are subverting the type system and also you are introducing alignment issues on platforms that have SIGBUS for unaligned memory accesses. void* has no alignment requirements but int* does.
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2024-11-01 16:01 fefe New Issue
2024-11-03 20:34 schanzen Target Version => 0.22.3
2024-11-03 20:43 schanzen Assigned To => schanzen
2024-11-03 20:43 schanzen Status new => resolved
2024-11-03 20:43 schanzen Resolution open => fixed
2024-11-14 09:43 schanzen Target Version 0.22.3 => 0.23.0