View Issue Details

IDProjectCategoryView StatusLast Update
0009308GNUnetutil librarypublic2024-11-14 09:44
Reporterfefe Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Target Version0.23.0 
Summary0009308: GNUNET_DISK_file_read_non_blocking: function makes no sense
DescriptionThe function sets the O_NONBLOCK flag on a descriptor, does a read, and then un-sets the flag again.
The functiojn name explicitly says DISK. That flag does not apply to disk files.

It does apply to pipes and sockets however, and for those doing what the function does may be harmful, because that flag applies to the underlying pipe object in the kernel, not just to the descriptor. See https://cr.yp.to/unix/nonblock.html for a list of the problems.

Why do you even have this function?
TagsNo tags attached.

Activities

schanzen

2024-11-03 21:02

administrator   ~0023644

It is not used anywhere. I vote to remove/deprecate.

Christian Grothoff

2024-11-04 07:30

manager   ~0023647

I agree, let's remove it.

Issue History

Date Modified Username Field Change
2024-11-01 14:43 fefe New Issue
2024-11-03 20:34 schanzen Target Version => 0.22.3
2024-11-03 21:02 schanzen Note Added: 0023644
2024-11-03 21:02 schanzen Assigned To => Christian Grothoff
2024-11-03 21:02 schanzen Status new => assigned
2024-11-04 07:30 Christian Grothoff Note Added: 0023647
2024-11-04 07:33 Christian Grothoff Status assigned => resolved
2024-11-04 07:33 Christian Grothoff Resolution open => fixed
2024-11-04 07:33 Christian Grothoff Fixed in Version => 0.22.3
2024-11-14 09:43 schanzen Target Version 0.22.3 => 0.23.0
2024-11-14 09:44 schanzen Fixed in Version 0.22.3 =>