View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009298 | GNUnet | util library | public | 2024-10-25 10:17 | 2024-10-29 20:56 |
| Reporter | fefe | Assigned To | schanzen | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.22.2 | Fixed in Version | 0.22.2 | ||
| Summary | 0009298: derive_h: salt is not random | ||||
| Description | In crypto_ecc_gnsrecord.c function derive_h: 54 static const char *const salt = "key-derivation"; A salt is by definition random, not static. At least add a comment here explaining what you are trying to do. Similar situation in crypto_edx25519.c function derive_h: 223 static const char *const salt = "edx25519-derivation"; | ||||
| Tags | No tags attached. | ||||
|
|
This is a key derivation salt. As common in KDF salts (https://www.rfc-editor.org/rfc/rfc8446#section-7.1) the value primarily servers as a domain-separation for the underlying PRF of HKDF (which is HKDF-Extract/HMAC). This has nothing to do with password hashing. It is kind of unfortunate that HKDF calls this input value a salt, but it is what it is. |
|
|
More context: https://crypto.stackexchange.com/questions/64150/hkdf-ikm-salt-and-info-values |
|
|
Fix committed to master branch. |
|
|
Released |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-10-25 10:17 | fefe | New Issue | |
| 2024-10-25 13:57 | schanzen | Note Added: 0023599 | |
| 2024-10-25 13:59 | schanzen | Note Added: 0023600 | |
| 2024-10-25 14:03 | schanzen | Note Edited: 0023599 | |
| 2024-10-29 13:22 | schanzen | Changeset attached | => gnunet master 57b21aa7 |
| 2024-10-29 13:22 | schanzen | Note Added: 0023617 | |
| 2024-10-29 13:22 | schanzen | Assigned To | => schanzen |
| 2024-10-29 13:22 | schanzen | Status | new => resolved |
| 2024-10-29 13:22 | schanzen | Resolution | open => fixed |
| 2024-10-29 13:22 | schanzen | Fixed in Version | => 0.22.2 |
| 2024-10-29 13:22 | schanzen | Target Version | => 0.22.2 |
| 2024-10-29 20:56 | schanzen | Note Added: 0023622 | |
| 2024-10-29 20:56 | schanzen | Status | resolved => closed |
