View Issue Details

IDProjectCategoryView StatusLast Update
0009151Talerwallet (Android App)public2024-09-13 13:48
Reportermikolai Assigned Toavalos  
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version0.12 
Target Version0.14Fixed in Version0.14 
Summary0009151: Deposit to bank shows IBAN form instead of x-taler-bank or payto-link
DescriptionWith the default regional-currency setup (with foreseen ebics-cashin), the regional currency bank uses account names instead of IBAN. The money deposit to bank account form should thus allow entering an account name instead of an IBAN.
Steps To Reproduce0. Follow the standard regional currency deployment script with fiat conversion (no actual ebics needed for now)
1. Check https://exchange.$HOST/keys to see that the x-taler-bank account has no restrictions on debit, while the iban account is restricted with "deny"
2. Get some money
3. Click on "Send"
4. Enter an amount
5. Click on "to a bank account"
6. see the form asking for IBAN instead of an account name
Additional InformationIf you don't have such a deployment at hand, you can test with the Datenspuren deployment at $HOST = taler.datenspuren.de
Here is some money to debug with, please receive, take some cents and initiate a new p2p payment with the rest for other people to use:

taler://pay-push/exchange.taler.datenspuren.de/4T5D8XY9NXB1VRD8HHJFV6DBD9VMGPB458VDX1DWFVGP8HNE7Z70
TagsNo tags attached.

Activities

avalos

2024-09-03 22:39

developer   ~0023154

WIP has been pushed to dev/ivan-avalos/x-taler-bank.

[estimate: 6h]
image.png (42,639 bytes)   
image.png (42,639 bytes)   
image-2.png (48,768 bytes)   
image-2.png (48,768 bytes)   

mikolai

2024-09-04 09:27

developer   ~0023156

Looks good, but I wouldn't have expected to be able to input the bank ("host") manually, shouldn't that be restricted by the exchange account anyway (i.e. there is no inter-bank transaction support between different x-taler-banks, right?)

the information of the host is part of the payto url in /keys .accounts

avalos

2024-09-04 09:56

developer   ~0023157

Yes, that's true, but a wallet can have multiple exchanges configured for a single currency, we can't make decisions based on only a single one of them.

mikolai

2024-09-04 10:23

developer   ~0023158

I see, but then at least it should be a drop-down providing all the possible options from all configured exchanges (and optionally, if only one is available, hide the drop-down altogether).

avalos

2024-09-05 20:11

developer   ~0023183

Consider this an initial version that will be improving over iterations, I don't want a seemingly simple feature to delay 0.13.1, especially if it's not critical, can that be a separate ticket?

mikolai

2024-09-06 07:17

developer   ~0023200

That's okay with me, will you open the new ticket?

Christian Grothoff

2024-09-09 10:05

manager   ~0023212

We shouldn't have a way to input the x-taler-bank hostname, that's fixed (no federation!). But if an exchange has multiple bank accounts, the wallet should have a *notebook* (or drop down, but better notebook) to allow the user to switch between them. We also have a priority field that tells the wallet in which order to show the different bank accounts.

avalos

2024-09-10 12:21

developer   ~0023222

Okay, I implemented the dropdown.
Screenshot_20240910-121937.png (71,984 bytes)   
Screenshot_20240910-121937.png (71,984 bytes)   

avalos

2024-09-13 11:52

developer   ~0023282

Fixed and released in version 0.13.2.

Issue History

Date Modified Username Field Change
2024-09-02 10:44 mikolai New Issue
2024-09-02 10:44 mikolai Status new => assigned
2024-09-02 10:44 mikolai Assigned To => Florian Dold
2024-09-02 10:50 mikolai Assigned To Florian Dold => avalos
2024-09-03 11:12 Christian Grothoff Priority normal => high
2024-09-03 11:12 Christian Grothoff Target Version => 0.14
2024-09-03 22:39 avalos Note Added: 0023154
2024-09-03 22:39 avalos File Added: image.png
2024-09-03 22:39 avalos File Added: image-2.png
2024-09-04 09:27 mikolai Note Added: 0023156
2024-09-04 09:56 avalos Note Added: 0023157
2024-09-04 10:23 mikolai Note Added: 0023158
2024-09-05 20:11 avalos Note Added: 0023183
2024-09-06 07:17 mikolai Note Added: 0023200
2024-09-09 10:05 Christian Grothoff Note Added: 0023212
2024-09-10 12:21 avalos Note Added: 0023222
2024-09-10 12:21 avalos File Added: Screenshot_20240910-121937.png
2024-09-13 11:52 avalos Status assigned => resolved
2024-09-13 11:52 avalos Resolution open => fixed
2024-09-13 11:52 avalos Note Added: 0023282
2024-09-13 13:48 Christian Grothoff Fixed in Version => 0.14