View Issue Details

IDProjectCategoryView StatusLast Update
0009139Talermechant backendpublic2024-08-28 21:09
Reporteravalos Assigned To 
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status acknowledgedResolutionopen 
Summary0009139: In contract terms, store tax percent in addition to tax amount
DescriptionWhen storing a product with taxes in the inventory, the merchant API should require a percentage for each amount, so that the inventory staff doesn't have to manually calculate the taxes for every single product, and the wallet apps don't have to manually calculate the percentages (which could be inaccurate if rounding applies). The tax amount returned by the merchant API for every product should be rounded to full cents based on currency specification.
TagsNo tags attached.

Activities

Christian Grothoff

2024-08-28 15:37

manager   ~0023084

I am not sure this is at all what should be done here. Rounding is bad, percentages are bad. Tons of potential for problems with that.
Maybe the SPA could have some automation to help determine taxes for products better, but this here seems like an ad-hoc proposal for a complex problem that requires some deeper understanding.

MarcS

2024-08-28 21:09

developer   ~0023087

On german and austrian bills, there are usually 4 amounts in addition to the overall sum for each VAT value: Tax% (normal VAT 19% (DE) / 20% (AT), reduced VAT 7% (DE) / 10% (AT)), gros (total incl. tax), net (without tax), tax. Thus you often have 9 amounts (2x4 +1) on the bill - and you need them all for your tax declaration.
Tax percentage is only to group the goods: regular 19% / 20% vs reduced 7% / 10%. It is more a label than a value.
And of course the merchant always needs to round to the cent (or rather smallest coin of the currency), since fractions of a cent are not possible in the total even if goods (e.g. fuel or electricity) are sold with fractions per unit.
Thus no problems at all (for the wallets) with tax percentage and tax amounts. We ignore them completely for the payment (just pay the total sum), but we have to show them to the user in the transaction details (receipt).

Issue History

Date Modified Username Field Change
2024-08-27 11:56 avalos New Issue
2024-08-27 11:56 avalos Status new => assigned
2024-08-27 11:56 avalos Assigned To => Christian Grothoff
2024-08-27 12:24 MarcS Summary In contract terms, store tax percent instead of tax amount => In contract terms, store tax percent in addition to tax amount
2024-08-27 12:24 MarcS Description Updated
2024-08-28 15:36 Christian Grothoff Severity minor => feature
2024-08-28 15:37 Christian Grothoff Assigned To Christian Grothoff =>
2024-08-28 15:37 Christian Grothoff Status assigned => acknowledged
2024-08-28 15:37 Christian Grothoff Note Added: 0023084
2024-08-28 21:09 MarcS Note Added: 0023087