View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008979 | GNUnet | util library | public | 2024-06-25 15:36 | 2024-07-09 19:05 |
| Reporter | thejackimonster | Assigned To | |||
| Priority | normal | Severity | crash | Reproducibility | random |
| Status | new | Resolution | open | ||
| Product Version | Git master | ||||
| Summary | 0008979: MQ: Send fails because envelope queue is not empty | ||||
| Description | I was testing the messenger-gtk application and I assume because the voice chat feature, I'm working on, sends quite a bit of messages, it was possible that the application just crashed because of an assertion in the message queue. I'm not sure whether this is just a missing check in the implementation or not. Because right in front of the assertion, it verifies that there's not current envelope or sending task. However it doesn't actually verify the envelope queue is empty. The assertion just assumes this. So maybe this is easy to fix by adding a `(NULL != mq->envelope_head)` to the brach and adding a new envelope to the queue in that case. | ||||
| Steps To Reproduce | I randomly ran into this testing around with the Messenger-GTK application. Couldn't easily reproduce it but sometimes it happens. | ||||
| Additional Information | Assertion that causes the crash: https://git.gnunet.org/gnunet.git/tree/src/lib/util/mq.c#n328 Messenger-GTK repository: https://git.gnunet.org/messenger-gtk.git/ | ||||
| Tags | No tags attached. | ||||
|
|
I ran into another issue when using the code from gnunet-gtk to merge the g_main_loop from GTK and the scheduler from GNUnet into a single thread. While I could still reproduce the problem described above. At times I also tripped over another assertion in client.c: https://git.gnunet.org/gnunet.git/tree/src/lib/util/client.c#n849 |
|
|
I've implemented a short patch to fix it and I think that should work out. https://git.gnunet.org/gnunet.git/commit/?id=4ba0256369aaa141e558329d59df058acd5e3e64 |
|
|
I've implemented a second patch to optimize sending in the regard that `GNUNET_MQ_send()` will still send a message in case the queue has not been empty. So it won't run into the case of piling up envelopes without sending any. https://git.gnunet.org/gnunet.git/commit/?id=cc17efdd940dc6abad29e51765d2fbf44953afdd |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-06-25 15:36 | thejackimonster | New Issue | |
| 2024-07-01 20:47 | thejackimonster | Note Added: 0022778 | |
| 2024-07-04 22:26 | thejackimonster | Note Added: 0022786 | |
| 2024-07-09 19:05 | thejackimonster | Note Added: 0022804 |
