View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008718 | Taler | libeufin-bank | public | 2024-04-09 17:02 | 2024-04-15 21:32 |
| Reporter | sebasjm | Assigned To | Antoine A | ||
| Priority | urgent | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.10 | Fixed in Version | 0.10 | ||
| Summary | 0008718: change reference from `demobank-ui` to `bank-ui` | ||||
| Description | in 0.10 i changed the name of demobank to @gnu-taler/bank-ui it will be nice to keep it consistent in order places, i found some references in libeufin manpages and debian packages but i haven't look in everyplace. | ||||
| Tags | No tags attached. | ||||
|
|
I still see: contrib/copy_spa.sh:cp contrib/wallet-core/bank/* debian/usr/share/libeufin/demobank-ui/ debian/usr/share/libeufin/demobank-ui/index.html: <script src="demobank-ui-settings.js"></script> debian/libeufin-sandbox/usr/share/libeufin/demobank-ui/index.html: <script src="demobank-ui-settings.js"></script> debian/libeufin-sandbox/etc/nginx/sites-available/libeufin-sandbox: alias /usr/share/libeufin/demobank-ui/; debian/libeufin-sandbox/etc/nginx/sites-available/libeufin-sandbox: alias /etc/libeufin/demobank-ui-settings.js; |
|
|
Also in docs.git: design-documents/index.rst: 038-demobanks-protocol-suppliers.rst (all over that document) manpages/libeufin-cli.1.rst: also tons of talk about 'demobank' |
|
|
And in wallet-core.git: taler-harness/lib/harness/libeufin-apis.d.ts: function createDemobankEbicsSubscriber(req: CreateEbicsSubscriberRequest, demobankAccountLabel: string, libeufinSandboxService: LibeufinSandboxServiceInterface, username?: string, password?: string): Promise<void>; taler-wallet-cli/lib/harness/libeufin-apis.d.ts: * Note: the demobank serving the request is hard-coded taler-wallet-cli/lib/harness/libeufin-apis.d.ts: function demobankAccountInfo(username: string, password: string, libeufinSandboxService: LibeufinSandboxServiceInterface, accountLabel: string): Promise<axiosImp.AxiosResponse<any, any>>; taler-wallet-cli/lib/harness/libeufin-apis.d.ts: function createDemobankEbicsSubscriber(req: CreateEbicsSubscriberRequest, demobankAccountLabel: string, libeufinSandboxService: LibeufinSandboxServiceInterface, username?: string, password?: string): Promise<void>; |
|
|
I agree that it's time for "demobank[-ui]" to die and for it to become "bank-ui" or "libeufin-bank" respectively. That said, this is right now the *last* blocker in the bugtracker for me to finish packaging exchange/merchant/libeufin/challenger/sync, so I'd appreciate it getting resolved ;-) |
|
|
Is anyone working on this? This is the one issue blocking me from updating the packages for 0.10! |
|
|
For me, 038-demobanks-protocol-suppliers.rst, libeufin-cli and libeufin-sandbox are dead and therefore don't need to be fixed. As libeufin-bank already supports SPA renaming, this is more of a cosmetic problem than a functional one, so you can pack 0.10 |
|
|
I change some comments and function name in wallet-core.git at 16405fe33..516bda58b libeufin-apis.d.ts doesn't seems to exist |
|
|
14.9 in docs.git was still a man page for libeufin-cli. I removed it now. 14.12 in docs.git was still a man page for libeufin-cli. I removed it now. |
|
|
Could someone then please clarify what is left to do here? DD38 is XX38, so that's OK. Man pages were now removed, but please clarify what should be done here for 0.11 then... |
|
|
my concern was that a change in wallet-core.git may break something in libeufin, non cosmetic > libeufin-bank already supports SPA renaming then this issue can be closed |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-04-09 17:02 | sebasjm | New Issue | |
| 2024-04-09 17:02 | sebasjm | Status | new => assigned |
| 2024-04-09 17:02 | sebasjm | Assigned To | => Antoine A |
| 2024-04-09 23:01 | Christian Grothoff | Priority | normal => high |
| 2024-04-09 23:01 | Christian Grothoff | Severity | minor => tweak |
| 2024-04-09 23:01 | Christian Grothoff | Product Version | 0.11 => git (master) |
| 2024-04-09 23:01 | Christian Grothoff | Target Version | => 0.10 |
| 2024-04-11 00:04 | Christian Grothoff | Note Added: 0022202 | |
| 2024-04-11 00:07 | Christian Grothoff | Note Added: 0022203 | |
| 2024-04-11 00:08 | Christian Grothoff | Note Added: 0022204 | |
| 2024-04-11 00:10 | Christian Grothoff | Note Added: 0022205 | |
| 2024-04-11 20:57 | Christian Grothoff | Note Added: 0022207 | |
| 2024-04-11 20:57 | Christian Grothoff | Priority | high => urgent |
| 2024-04-11 22:51 | Antoine A | Note Added: 0022210 | |
| 2024-04-11 22:51 | Antoine A | Note Edited: 0022210 | |
| 2024-04-11 23:15 | sebasjm | Note Added: 0022211 | |
| 2024-04-12 00:50 | Christian Grothoff | Note Added: 0022212 | |
| 2024-04-12 00:50 | Christian Grothoff | Target Version | 0.10 => 0.11 |
| 2024-04-12 00:51 | Christian Grothoff | Note Added: 0022213 | |
| 2024-04-12 02:54 | sebasjm | Note Added: 0022219 | |
| 2024-04-12 02:55 | sebasjm | Status | assigned => resolved |
| 2024-04-12 02:55 | sebasjm | Resolution | open => fixed |
| 2024-04-12 10:16 | Christian Grothoff | Fixed in Version | => 0.10 |
| 2024-04-12 10:16 | Christian Grothoff | Target Version | 0.11 => 0.10 |
| 2024-04-15 21:32 | Christian Grothoff | Status | resolved => closed |
