View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008549 | Taler | wallet (Android App) | public | 2024-02-29 15:32 | 2024-04-15 21:32 |
| Reporter | grote | Assigned To | grote | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.10 | Fixed in Version | 0.10 | ||
| Summary | 0008549: Paying p2p invoice without sufficient balance shows improper error | ||||
| Description | When attempting to pay an invoice greater than your balance, rather than it giving a human-readable error, it gives a JSON Object (see below) that doesn't properly fit on screen Reproduce: 1. Create invoice for $10 (on iOS device in my testing) 2. Attempt to pay on android device with less than $10 balance 3. See error $10 is just an example figure | ||||
| Tags | No tags attached. | ||||
|
|
I reproduced this, and addressed a bunch of JSON errors that were being shown to non-devs (check dev/ivan-avalos/master). However, the cryptic error message `Error (WALLET_PEER_PUSH_PAYMENT_INSUFFICIENT_BALANCE)` comes from wallet-core, so until we have better, i18n-ed errors in wallet-core, this remains a wallet-core issue. |
|
|
wasn't the main issue merged in https://git.taler.net/taler-android.git/commit/?id=0574cad9c5cdfef4775af5cbd5d9d6e5d588f2ce so maybe open a new ticket for wallet-core? |
|
|
Yes, I forgot about that, but the cryptic error remains, even if it's not a JSON object anymore. The error is still improper, but that's now on wallet-core. wallet-core still needs better errors + i18n. Should I close this bug? |
|
|
What's missing in the wallet-core error reporting, other than i18n? |
|
|
In this case, wallet-core should return a proper TalerErrorDetails with "code" and more information about why the balance is insufficient. But it's already doing that, IMO the UI just needs to render it nicely. |
|
|
In my opinion, this shouldn't be an error, but a state. Other parts of the API return an `InsufficientBalance` state when the balance is insufficient, and the UI can then decide how to render it based on the data contained in the state. I much prefer it to be that way. Either way, I have addressed this in dev/ivan-avalos/master, now pending review from Torsten. |
|
|
I agree with avalos that this should be a (n expected) state not an error like other unexpected conditions. |
|
|
still, addressed in https://git.taler.net/taler-android.git/commit/?id=39b6926dd32b0731d87ea8daa94c1d4c29d3d193 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-29 15:32 | grote | New Issue | |
| 2024-02-29 15:32 | grote | Status | new => assigned |
| 2024-02-29 15:32 | grote | Assigned To | => avalos |
| 2024-03-01 05:17 | avalos | Note Added: 0021594 | |
| 2024-03-08 20:45 | Christian Grothoff | Target Version | => 0.10 |
| 2024-03-13 19:59 | avalos | Assigned To | avalos => Florian Dold |
| 2024-03-13 19:59 | avalos | Status | assigned => feedback |
| 2024-03-13 21:29 | grote | Note Added: 0021907 | |
| 2024-03-13 21:29 | grote | Status | feedback => assigned |
| 2024-03-13 21:30 | grote | Note Edited: 0021907 | |
| 2024-03-13 21:32 | avalos | Note Added: 0021908 | |
| 2024-03-13 21:36 | Florian Dold | Note Added: 0021911 | |
| 2024-03-13 21:37 | Florian Dold | Note Added: 0021912 | |
| 2024-03-13 21:38 | Florian Dold | Assigned To | Florian Dold => avalos |
| 2024-03-22 19:33 | avalos | Assigned To | avalos => grote |
| 2024-03-22 19:33 | avalos | Status | assigned => feedback |
| 2024-03-22 19:33 | avalos | Note Added: 0021979 | |
| 2024-03-25 18:12 | grote | Note Added: 0021987 | |
| 2024-03-25 18:12 | grote | Status | feedback => resolved |
| 2024-03-25 18:12 | grote | Resolution | open => fixed |
| 2024-03-25 18:12 | grote | Note Added: 0021988 | |
| 2024-04-09 13:11 | Christian Grothoff | Fixed in Version | => 0.10 |
| 2024-04-15 21:32 | Christian Grothoff | Status | resolved => closed |
