View Issue Details

IDProjectCategoryView StatusLast Update
0008536Talerwallet (Android App)public2024-03-07 20:51
ReporterFlorian Dold Assigned Togrote  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008536: show version info even when not in developer mode
DescriptionThis is something that's relevant for non-developer users as well.
TagsNo tags attached.

Relationships

child of 0008511 closedavalos release Android wallet release candidate on F-droid and Google stores [deadline: 27. Feb] 

Activities

grote

2024-02-28 18:28

developer   ~0021561

Even the version code, or just the version name?

@avalos, I think the way we are abusing the settings isn't the best way to expose stuff to non-devs. Maybe the version name in the drawer is sufficient? Or have some sort of About dialog?

avalos

2024-03-04 16:04

developer   ~0021638

We should have an about dialog, but I feel like it's appropriate to show the version info in the settings, just like Android has always done for the OS version since the beginning. No big deal using the settings for that. And the way the version code is exposed right now, that includes the flavor of the app, makes it easier to tell where users install the app from; I think we should leave it there.

avalos

2024-03-04 16:08

developer   ~0021641

In the latest commit in `dev/ivan-avalos/master`, the wallet-core version is now hidden for non-devs, but the app version remains shown by default, including the flavor and version code.

Christian Grothoff

2024-03-04 17:07

manager   ~0021646

Ok, grote: any issues why this is not yet merged and resolved? We want to release 0.9.4 ASAP...

grote

2024-03-05 15:11

developer   ~0021676

> any issues why this is not yet merged and resolved?

yes, see my concerns above, but if you want to expose technical and confusing information to non-developers in main parts of the UI, sure I can just merge this, if getting 0.9.4 with all tickets out is more important than good UX.

grote

2024-03-05 16:06

developer   ~0021686

fixed in https://git.taler.net/taler-android.git/commit/?id=b3119118d5fb1e19cf71265d20408f1f601a1ee3

Issue History

Date Modified Username Field Change
2024-02-28 01:01 Florian Dold New Issue
2024-02-28 01:01 Florian Dold Status new => assigned
2024-02-28 01:01 Florian Dold Assigned To => avalos
2024-02-28 18:28 grote Note Added: 0021561
2024-03-04 16:04 avalos Note Added: 0021638
2024-03-04 16:08 avalos Assigned To avalos => grote
2024-03-04 16:08 avalos Status assigned => feedback
2024-03-04 16:08 avalos Note Added: 0021641
2024-03-04 17:07 Christian Grothoff Note Added: 0021646
2024-03-04 17:19 Christian Grothoff Relationship added child of 0008511
2024-03-05 15:11 grote Note Added: 0021676
2024-03-05 16:06 grote Status feedback => resolved
2024-03-05 16:06 grote Resolution open => fixed
2024-03-05 16:06 grote Note Added: 0021686
2024-03-07 20:50 Christian Grothoff Fixed in Version => 0.9.4
2024-03-07 20:51 Christian Grothoff Status resolved => closed