View Issue Details

IDProjectCategoryView StatusLast Update
0008483Talerexchangepublic2024-03-07 20:51
ReporterFlorian Dold Assigned Tosebasjm  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008483: exchange ToS are not properly rendered as HTML

(Sections aren't rendered correctly, title is odd ("no title"))
TagsNo tags attached.


related to 0008457 closedsebasjm webext requests ToS as text/xml and fails to render it 


Christian Grothoff

2024-02-21 21:32

manager   ~0021427

Last edited: 2024-02-21 21:33

Well, seems Stefan's conversion from Restructured Text to Markdown broke it. Do we know why it was converted to MD in the first place?

Christian Grothoff

2024-02-21 21:34

manager   ~0021428

Stefan, please clarify why you converted the (at the time working!) Restructured Text to Markdown for the Terms of service and privacy policy.


2024-02-22 08:07

developer   ~0021439

Look at which ends with Marc's note " The iOS app now successfully receives Markdown ToS."

Marc and I wanted to get MarkDown rendered instead of ugly plain text which is displayed very badly on iOS platforms. solved the issue that the ToS generator generated invalid MarkDown.

Now we should ask us whether there is a way to let a MarkDown-tagged text file be displayed properly as plain text. MarkDown is required for iOS. When I git blame the ToS file exchange-tos-v0.rst I see that my last changes were applied on December 14. Was the file not working since then??

Thank you for your contributions to solve this issue. It will be needed for getting translations of the Terms of Service started in Weblate as we are heading for a whole bunch of languages we have to translate to.


2024-02-22 08:09

developer   ~0021440

Oh, and I never touched exchange-pp-v0.rst.

Christian Grothoff

2024-02-22 08:43

manager   ~0021441

I see. Well, in that case the answer is simple: please revert to proper Restructured Text, as the taler-terms-generator had been fixed to generate MD itself from the RST inputs, and so the source should be Restructured Text and NOT markdown! It works nicely for the other RST files.


2024-02-22 10:12

developer   ~0021442

Let's see how it renders. Please make a new build and test it out. Thank you.

Christian Grothoff

2024-02-22 18:08

manager   ~0021460

Florian or Sebastian: I assume you can test this on / with sandcastle?


2024-02-22 18:35

developer   ~0021462

I would expect HEAD to automatically pick this up - that's the main reason for it's existence, isn't it?


2024-02-23 14:53

developer   ~0021480

still testing, but this is what I see... asking the exchange for text/html and server replies text/plain
image.png (64,519 bytes)   
image.png (64,519 bytes)   


2024-02-23 14:56

developer   ~0021481

That was similar 3 months ago, when iOS asked for text/markdown and first only got text/plain, and later the server claimed to send text/markdown but the content was still text/plain.
Took weeks until there finally was real markdown in the answer...

Christian Grothoff

2024-02-23 15:02

manager   ~0021482

I don't get it. Please do
curl -H 'Accept: text/plain'

curl -H 'Accept: text/html'


curl -H 'Accept: text/markdown'

I always get the result in the correct format!


2024-02-28 15:38

developer   ~0021552

this works locally

cache may be a separated issue

Issue History

Date Modified Username Field Change
2024-02-21 21:05 Florian Dold New Issue
2024-02-21 21:05 Florian Dold Status new => assigned
2024-02-21 21:05 Florian Dold Assigned To => Christian Grothoff
2024-02-21 21:32 Christian Grothoff Note Added: 0021427
2024-02-21 21:33 Christian Grothoff Note Edited: 0021427
2024-02-21 21:33 Christian Grothoff Assigned To Christian Grothoff => Stefan
2024-02-21 21:34 Christian Grothoff Note Added: 0021428
2024-02-21 22:34 sebasjm Relationship added related to 0008457
2024-02-22 08:07 Stefan Note Added: 0021439
2024-02-22 08:09 Stefan Note Added: 0021440
2024-02-22 08:43 Christian Grothoff Note Added: 0021441
2024-02-22 10:12 Stefan Note Added: 0021442
2024-02-22 18:08 Christian Grothoff Assigned To Stefan => sebasjm
2024-02-22 18:08 Christian Grothoff Note Added: 0021460
2024-02-22 18:35 MarcS Note Added: 0021462
2024-02-23 14:53 sebasjm Note Added: 0021480
2024-02-23 14:53 sebasjm File Added: image.png
2024-02-23 14:56 MarcS Note Added: 0021481
2024-02-23 15:02 Christian Grothoff Note Added: 0021482
2024-02-28 15:38 sebasjm Status assigned => resolved
2024-02-28 15:38 sebasjm Resolution open => fixed
2024-02-28 15:38 sebasjm Note Added: 0021552
2024-03-07 20:50 Christian Grothoff Fixed in Version => 0.9.4
2024-03-07 20:51 Christian Grothoff Status resolved => closed