View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007882 | Taler | wallet-core | public | 2023-07-05 17:41 | 2024-03-07 20:49 |
| Reporter | MarcS | Assigned To | sebasjm | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Product Version | 0.9.3 | ||||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0007882: ToS is always text/plain, even if you ask for text/markdown only | ||||
| Description | If you call getExchangeTos with the optional format parameter acceptedFormat: [String] = ["text/markdown", "text/plain"] it should return markdown, and only if this is not possible return plain text. exchange.demo.taler.net returns always plain text (as of 23-07-05) | ||||
| Tags | No tags attached. | ||||
| related to | 0008003 | closed | Christian Grothoff | tos generator generates invalid markdown |
|
|
There was a bug exchange-side where it didn't work properly if there were multiple accepted mime-types given. 1db17d43..40dfb94e fixes this. |
|
|
This needs some more thorough look in wallet-core. How important is this? We might fold it in with the exchange API refactor (proper state machine) otherwise. |
|
|
I'd say moderate. ToS is one of the first things we show to the user, and it should be rendered as nicely as possible. But of course the current TXT can be rendered kind-of OK so not too critical. |
|
|
It would be great to see an integration test for this. |
|
|
d0d19c2e8..ef5962cd3 |
|
|
This was not fixed. I never ever saw a MarkDown ToS, yet... |
|
|
wget --header 'Accept: application/pdf' http://127.0.0.1:8081/terms => PDF wget --header 'Accept: text/html' http://127.0.0.1:8081/terms => HTML wget --header 'Accept: text/plain' http://127.0.0.1:8081/terms => TEXT/MD So works on the exchange-side as far as I can tell. |
|
|
please provide an example of the wallet operation call and what wallet-core returns. |
|
|
While DEMO now for the first time claims to return "text/markdown” ToS, the content is still the plaintext version: WalletCore#1 sendRequest(request:completionHandler:) {"id":4,"operation":"getExchangeTos","args":{"acceptedFormat":["text\/markdown","text\/plain"],"exchangeBaseUrl":"https:\/\/exchange.demo.taler.net\/"}} WalletCore#1 handleResponse(_:) id:4 ["tosStatus": "proposed", "contentType": "text/markdown", "currentEtag": "exchange-tos-v0", "content": "Terms of Service\n****************\n\nLast updated: 1.11.2023\n\nWelcome! Taler Systems SA (“we,” “our,” or “us”) provides a payment\nservice through our Internet presence (collectively the “Services”).\n... |
|
|
The iOS app now successfully receives Markdown ToS. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-07-05 17:41 | MarcS | New Issue | |
| 2023-07-05 17:41 | MarcS | Status | new => assigned |
| 2023-07-05 17:41 | MarcS | Assigned To | => Florian Dold |
| 2023-07-05 18:18 | Christian Grothoff | Note Added: 0020340 | |
| 2023-07-24 10:50 | Florian Dold | Note Added: 0020364 | |
| 2023-07-24 11:41 | Christian Grothoff | Note Added: 0020370 | |
| 2023-08-03 20:45 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2023-08-03 20:45 | Florian Dold | Note Added: 0020408 | |
| 2023-08-23 15:46 | sebasjm | Status | assigned => resolved |
| 2023-08-23 15:46 | sebasjm | Resolution | open => fixed |
| 2023-08-23 15:46 | sebasjm | Note Added: 0020431 | |
| 2023-09-23 15:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 15:09 | Christian Grothoff | Status | resolved => closed |
| 2023-11-27 12:44 | MarcS | Status | closed => feedback |
| 2023-11-27 12:44 | MarcS | Resolution | fixed => reopened |
| 2023-11-27 12:44 | MarcS | Note Added: 0020666 | |
| 2023-11-28 09:18 | Christian Grothoff | Note Added: 0020667 | |
| 2023-11-29 01:28 | Christian Grothoff | Fixed in Version | 0.9.3 => |
| 2023-11-29 01:28 | Christian Grothoff | Target Version | 0.9.3 => 0.9.4 |
| 2023-11-29 12:26 | sebasjm | Assigned To | sebasjm => MarcS |
| 2023-11-29 12:27 | sebasjm | Note Added: 0020672 | |
| 2023-12-05 19:20 | MarcS | Note Added: 0020730 | |
| 2023-12-05 19:21 | MarcS | Assigned To | MarcS => sebasjm |
| 2023-12-11 13:41 | MarcS | Relationship added | related to 0008003 |
| 2023-12-21 20:41 | MarcS | Status | feedback => resolved |
| 2023-12-21 20:41 | MarcS | Note Added: 0020783 | |
| 2024-02-10 23:31 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-03-07 20:49 | Christian Grothoff | Status | resolved => closed |
