View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008481 | Taler | wallet-core | public | 2024-02-21 20:38 | 2024-03-07 20:51 |
| Reporter | Florian Dold | Assigned To | sebasjm | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008481: in the "pay with mobile wallet flow", the browser wallet does not redirect to the fulfillment URL when payment is done | ||||
| Description | Instead, it stays on the same payment confirmation page. | ||||
| Tags | No tags attached. | ||||
| child of | 0008121 | closed | Florian Dold | upload final 0.9.4 webext to Chrome Web Store |
|
|
wallet core is not sending any event to notify the UI the change. observability already paying out |
|
|
fixed in dev/sebasjm/fix-8481 with some comments in the commit msg |
|
|
Is there any particular reason why this is a `paidByOther` flag and not a new `failed(paid-by-other)` state? |
|
|
yes, good enough solution to fix the blocking issue of "wallet1 is not redirecting after wallet2 paid the shared proposal". we should include the sharing feature into the sates of payment and maybe prevent the first wallet to start the payment if the purchase was shared. |
|
|
That is not really a good enough reason, I don't think that adding the new minor state is really a much bigger change than the flag. We should not do these workarounds that break our nice conceptual model. Could you please add the new minor state? When you handle the new state in the webext, mobile wallets shouldn't break, as they don't call the payment sharing API. |
|
|
`dev/sebasjm/fix-8481 a6473f4c0` add the assertion on the test integration |
|
|
was merge by fdold in 2dd1bbebc |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-21 20:38 | Florian Dold | New Issue | |
| 2024-02-21 20:38 | Florian Dold | Status | new => assigned |
| 2024-02-21 20:38 | Florian Dold | Assigned To | => Florian Dold |
| 2024-02-22 11:01 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2024-03-01 13:45 | sebasjm | Category | wallet (WebExtension) => wallet-core |
| 2024-03-01 13:47 | sebasjm | Note Added: 0021602 | |
| 2024-03-01 16:00 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2024-03-01 16:00 | sebasjm | Status | assigned => feedback |
| 2024-03-01 16:00 | sebasjm | Note Added: 0021606 | |
| 2024-03-04 13:19 | Florian Dold | Note Added: 0021634 | |
| 2024-03-04 13:20 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2024-03-04 13:37 | sebasjm | Note Added: 0021635 | |
| 2024-03-04 13:37 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2024-03-04 16:53 | Florian Dold | Note Added: 0021643 | |
| 2024-03-04 16:53 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2024-03-04 16:53 | Florian Dold | Status | feedback => assigned |
| 2024-03-04 17:11 | Christian Grothoff | Relationship added | child of 0008121 |
| 2024-03-04 18:38 | sebasjm | Note Added: 0021656 | |
| 2024-03-06 16:36 | sebasjm | Status | assigned => resolved |
| 2024-03-06 16:36 | sebasjm | Resolution | open => fixed |
| 2024-03-06 16:36 | sebasjm | Note Added: 0021730 | |
| 2024-03-07 20:50 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-03-07 20:51 | Christian Grothoff | Status | resolved => closed |
