View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008415 | Taler | wallet-core | public | 2024-02-15 23:36 | 2024-03-07 20:52 |
| Reporter | Florian Dold | Assigned To | Florian Dold | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008415: investigate odd transition to failed(claim) in payment sharing | ||||
| Description | The test case indicates that the transaction that was shared should be able to *succeed* after calling confirmPay on it, even if the second wallet (that received the shared taler://pay URI) already paid for it. However, the current implementation seems to transition to failed(claim) instead. | ||||
| Tags | No tags attached. | ||||
|
|
DD 37 does not spec sharing payment (we implemented this before AFAIK) test fail because of timeout: w1: claim an order w1 share the payment with w2 w2 pays w1 tries to confirm the operation w1 never returns. The operation hang bug is not related to the share feature: wallet-core doing waitPaymentResult and no notification arrives to stop it (what if the notification happens before doing waitPaymentResult?) In this case the tx is failed:(claim) it should not wait, just return. Regarding the the test definition it think it needs more discussion first because it not in the spec, second becuase I can get the coins from my friend when asking refund of a shared payment. |
|
|
after 366e1fb65..90c7dc49b now wallet-core is checking if the state of the purchase is beyond "done", any state after done will return ConfirmPayResultType.Done (which doesn't mean success) |
|
|
LGTM, test passes again. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-02-15 23:36 | Florian Dold | New Issue | |
| 2024-02-15 23:36 | Florian Dold | Status | new => assigned |
| 2024-02-15 23:36 | Florian Dold | Assigned To | => sebasjm |
| 2024-02-16 19:35 | sebasjm | Note Added: 0021326 | |
| 2024-02-16 20:11 | sebasjm | Note Added: 0021327 | |
| 2024-02-16 20:11 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2024-02-16 20:11 | sebasjm | Status | assigned => feedback |
| 2024-02-18 15:10 | Florian Dold | Status | feedback => resolved |
| 2024-02-18 15:10 | Florian Dold | Resolution | open => fixed |
| 2024-02-18 15:10 | Florian Dold | Note Added: 0021342 | |
| 2024-03-07 20:52 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-03-07 20:52 | Christian Grothoff | Status | resolved => closed |
