View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008186 | Taler | Web site(s) | public | 2024-01-22 14:31 | 2024-03-07 20:52 |
| Reporter | dvn | Assigned To | dvn | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 0.9.4 | ||||
| Summary | 0008186: linkchecker failing on demo shop links | ||||
| Description | Linkchecker always fails on demo.taler.net because it checks /orders/ links. These links need to be ignored. | ||||
| Tags | No tags attached. | ||||
|
|
Thank you for reporting, Devan. May I suggest forwarding this issue - also as report only - to Florian? To my latest knowledge he wanted to care about the demo. Please update me if this would not be the case. Thanks. |
|
|
Should indeed be assigned to Devan. |
|
|
Florian and I discussed this issue. After attempting and not succeeding to implement an "ignore-list" to our current wget-based script I will be looking into replacing it with this utility: https://linkcheck.github.io/linkchecker/ |
|
|
Switched to the aforementioned "linkchecker" utility, which has functionality for ignoring URLs based on regex. |
|
|
Sorry to say that we still get BuildBot messages stating that some demo links fail: https://buildbot.taler.net/#builders/7/builds/360 https://buildbot.taler.net/#builders/7/builds/359 https://buildbot.taler.net/#builders/7/builds/358 https://buildbot.taler.net/#builders/7/builds/357 I cannot help it. Therefore, I would like to request your feedback for this issue. Warm regards, Stefan |
|
|
Okay, so a few comments I think are relevant: 1. let's focus only on the *latest* run of the linkchecker, which at this time is: https://buildbot.taler.net/#/builders/7/builds/360 2. I understand that it's failing on demo links, but are these links which should be ignored, or fixed? If you don't know, then who does? 3. You know to click the `view all 398 lines` toggle on the build page, so you can see the whole log, right? See: https://buildbot.taler.net/#/builders/7/builds/360/steps/2/logs/stdio |
|
|
I see three really bad links in the report https://buildbot.taler.net/#/builders/7/builds/360 at line 91: https://docs.taler.net/doxygen/exchange --> 404 at line 99: https://docs.taler.net/doxygen/merchant/ --> 404 and at line 382: https://donations.demo.taler.net/en/checkout --> parameter 'donation_amount' required The other links are working but leading to a closed FSF bookshop and some webarchives that do not count too much. So, who is going to rectify the three links? Cheers, S. |
|
|
Florian, shall I add https://donations.demo.taler.net/en/checkout to the ignore list? |
|
|
Yes, as we'll also get a payment required status code for it. |
|
|
Okay, I will add it to the ignore list. Then we have these three, originating from https://shop.demo.taler.net/ https://web.archive.org/web/20120118201902/http://www.gnu.org/ - Error: 503 Service Temporarily Unavailable https://www.researchgate.net/publication/4980956_The_Case_Against_Intellectual_Property - Error: 403 Forbidden https://shop.fsf.org/product/free-software-free-society-2 - Error: 503 Service Temporarily Unavailable These all appear to be up (except, arguably the FSF shop), but I guess they don't like the crawler. |
|
|
The FSF shop predicts to stay up and be retrievable again as a shop at a certain period in time in 2024. You can leave this link, I assume. |
|
|
Okay, I've added those to the ignore list. https://git.taler.net/deployment.git/commit/?id=290bc0d46f1a44e1654e7e6b02318395d222294a |
|
|
Demo sites pass after adding links we don't want to check to the ignore list. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-22 14:31 | dvn | New Issue | |
| 2024-01-22 14:31 | dvn | Status | new => assigned |
| 2024-01-22 14:31 | dvn | Assigned To | => Stefan |
| 2024-01-22 14:59 | Stefan | Note Added: 0020954 | |
| 2024-01-22 15:00 | Stefan | Assigned To | Stefan => Florian Dold |
| 2024-01-22 22:03 | Florian Dold | Assigned To | Florian Dold => dvn |
| 2024-01-22 22:04 | Florian Dold | Note Added: 0020966 | |
| 2024-01-23 00:03 | dvn | Note Added: 0020974 | |
| 2024-01-30 00:49 | Christian Grothoff | Severity | major => tweak |
| 2024-02-18 21:21 | dvn | Status | assigned => resolved |
| 2024-02-18 21:21 | dvn | Resolution | open => fixed |
| 2024-02-18 21:21 | dvn | Note Added: 0021346 | |
| 2024-02-19 08:39 | Stefan | Status | resolved => feedback |
| 2024-02-19 08:39 | Stefan | Resolution | fixed => reopened |
| 2024-02-19 08:39 | Stefan | Note Added: 0021360 | |
| 2024-02-19 10:17 | dvn | Note Added: 0021363 | |
| 2024-02-19 11:31 | Stefan | Note Added: 0021365 | |
| 2024-02-19 11:32 | Stefan | Note Edited: 0021365 | |
| 2024-02-19 11:33 | dvn | Note Added: 0021366 | |
| 2024-02-19 11:35 | Florian Dold | Note Added: 0021367 | |
| 2024-02-19 11:47 | dvn | Note Added: 0021368 | |
| 2024-02-19 13:01 | Stefan | Note Added: 0021370 | |
| 2024-02-19 13:22 | dvn | Note Added: 0021371 | |
| 2024-02-19 13:23 | dvn | Status | feedback => resolved |
| 2024-02-19 13:23 | dvn | Resolution | reopened => fixed |
| 2024-02-19 13:23 | dvn | Note Added: 0021372 | |
| 2024-03-07 20:52 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-03-07 20:52 | Christian Grothoff | Status | resolved => closed |
