View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008129 | Taler | qtart | public | 2024-01-19 01:07 | 2024-03-07 20:52 |
| Reporter | Florian Dold | Assigned To | Florian Dold | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008129: double-check usage of sqlite3_reset | ||||
| Description | The way that we are using the function right now could possibly lead to errors of the *previous* transaction being re-reported. That means after a transaction failed, the *next* transaction also fails with an error from sqlite3_reset. This is not critical for wallet-core, since with the indexeddb-layer we rarely expect transactions to fail. However, we should still look at it. | ||||
| Tags | No tags attached. | ||||
|
|
Indeed, the reset should (also) happen *after* a prepared statement is executed. Otherwise, the next execution of the statement reports the error of the previously executed failed prepared statement. Fixed+tested here: commit 5f5da3552e8b23fec0f199f5c2a4dc3732aec30f (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Tue Feb 27 13:44:41 2024 +0100 sqlite: reset after running statement |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-19 01:07 | Florian Dold | New Issue | |
| 2024-01-19 01:07 | Florian Dold | Status | new => assigned |
| 2024-01-19 01:07 | Florian Dold | Assigned To | => Florian Dold |
| 2024-02-27 13:46 | Florian Dold | Status | assigned => resolved |
| 2024-02-27 13:46 | Florian Dold | Resolution | open => fixed |
| 2024-02-27 13:46 | Florian Dold | Note Added: 0021536 | |
| 2024-02-27 13:46 | Florian Dold | Target Version | 0.10 => 0.9.4 |
| 2024-03-07 20:52 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-03-07 20:52 | Christian Grothoff | Status | resolved => closed |
