View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0008106 | Taler | exchange | public | 2024-01-18 14:57 | 2024-03-07 20:47 |
Reporter | fefe | Assigned To | Christian Grothoff | ||
Priority | low | Severity | trivial | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | git (master) | ||||
Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
Summary | 0008106: denoms_cmp: comment is wrong | ||||
Description | This is in exchange/src/lib/exchange_api_handle.c: 715 /** 716 * Compare two denomination keys. Ignores revocation data. 717 * 718 * @param denom1 first denomination key 719 * @param denom2 second denomination key 720 * @return 0 if the two keys are equal (not necessarily 721 * the same object), 1 otherwise. 722 */ The function can also return any other value. 744 return GNUNET_memcmp (&tmp1, 745 &tmp2); ... which calls memcmp. memcmp can return arbitrary values. If you only want to test for equality, the comment should state "nonzero otherwise" | ||||
Tags | No tags attached. | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2024-01-18 14:57 | fefe | New Issue | |
2024-01-18 14:57 | fefe | Status | new => assigned |
2024-01-18 14:57 | fefe | Assigned To | => Christian Grothoff |
2024-01-18 22:25 | Christian Grothoff | Note Added: 0020909 | |
2024-01-18 22:25 | Christian Grothoff | Status | assigned => resolved |
2024-01-18 22:25 | Christian Grothoff | Resolution | open => fixed |
2024-01-18 22:25 | Christian Grothoff | Fixed in Version | => 0.9.4 |
2024-01-18 22:25 | Christian Grothoff | Product Version | => git (master) |
2024-01-18 22:25 | Christian Grothoff | Target Version | => 0.9.4 |
2024-01-18 23:31 | Christian Grothoff | Relationship added | child of 0008112 |
2024-03-07 20:47 | Christian Grothoff | Status | resolved => closed |