View Issue Details

IDProjectCategoryView StatusLast Update
0008106Talerexchangepublic2024-03-07 20:47
Reporterfefe Assigned ToChristian Grothoff  
PrioritylowSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008106: denoms_cmp: comment is wrong
DescriptionThis is in exchange/src/lib/exchange_api_handle.c:

 715 /**
 716 * Compare two denomination keys. Ignores revocation data.
 717 *
 718 * @param denom1 first denomination key
 719 * @param denom2 second denomination key
 720 * @return 0 if the two keys are equal (not necessarily
 721 * the same object), 1 otherwise.
 722 */

The function can also return any other value.

 744 return GNUNET_memcmp (&tmp1,
 745 &tmp2);

... which calls memcmp. memcmp can return arbitrary values.
If you only want to test for equality, the comment should state "nonzero otherwise"
TagsNo tags attached.

Relationships

child of 0008112 assignedfefe Merchant security review 

Activities

Christian Grothoff

2024-01-18 22:25

manager   ~0020909

Fixed in dbf84c51..53e679c9

Issue History

Date Modified Username Field Change
2024-01-18 14:57 fefe New Issue
2024-01-18 14:57 fefe Status new => assigned
2024-01-18 14:57 fefe Assigned To => Christian Grothoff
2024-01-18 22:25 Christian Grothoff Note Added: 0020909
2024-01-18 22:25 Christian Grothoff Status assigned => resolved
2024-01-18 22:25 Christian Grothoff Resolution open => fixed
2024-01-18 22:25 Christian Grothoff Fixed in Version => 0.9.4
2024-01-18 22:25 Christian Grothoff Product Version => git (master)
2024-01-18 22:25 Christian Grothoff Target Version => 0.9.4
2024-01-18 23:31 Christian Grothoff Relationship added child of 0008112
2024-03-07 20:47 Christian Grothoff Status resolved => closed