View Issue Details

IDProjectCategoryView StatusLast Update
0008100Talerexchangepublic2024-03-07 20:47
Reporterfefe Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008100: parse_restrictions: integer truncation
DescriptionThis is in exchange/src/lib/exchange_api_common.c:

  412 static enum GNUNET_GenericReturnValue
  413 parse_restrictions (const json_t *jresta,
  414 unsigned int *resta_len,
  415 struct TALER_EXCHANGE_AccountRestriction **resta)

  422 *resta_len = json_array_size (jresta);

json_array_size returns size_t, so resta_len should either be a size_t* orr there should be a check or assertion here to make sure no truncation happened.
TagsNo tags attached.

Relationships

child of 0008112 assignedfefe Merchant security review 

Activities

Christian Grothoff

2024-01-17 19:34

manager   ~0020901

Fixed in 91969f18..3db8ffe5 (by first assigning to a size_t, then asserting that unsigned int doens't change the numeric value).

Issue History

Date Modified Username Field Change
2024-01-17 15:48 fefe New Issue
2024-01-17 15:48 fefe Status new => assigned
2024-01-17 15:48 fefe Assigned To => Christian Grothoff
2024-01-17 19:34 Christian Grothoff Status assigned => resolved
2024-01-17 19:34 Christian Grothoff Resolution open => fixed
2024-01-17 19:34 Christian Grothoff Fixed in Version => 0.9.4
2024-01-17 19:34 Christian Grothoff Note Added: 0020901
2024-01-17 19:35 Christian Grothoff Product Version => git (master)
2024-01-17 19:35 Christian Grothoff Target Version => 0.9.4
2024-01-18 23:31 Christian Grothoff Relationship added child of 0008112
2024-03-07 20:47 Christian Grothoff Status resolved => closed