View Issue Details

IDProjectCategoryView StatusLast Update
0008069Talerauditorpublic2024-03-07 20:49
Reporterfefe Assigned Tooec  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008069: perform_protocol: wrong fail check
DescriptionThis is in exchange/src/lib/exchange_api_age_withdraw.c:

   570 FAIL_IF (0 < json_array_append_new (j_denoms,
   571 jdenom));

According to the jansson API reference, json_array_append_new returns 0 on success and -1 on error.
This check looks for positive return values, which cannot happen.
TagsNo tags attached.

Activities

fefe

2024-01-11 17:01

developer   ~0020863

Oops sorry this should be exchange not auditor (according to the filename) There is also several more occurrances of this pattern in the same file.

oec

2024-01-12 11:59

developer   ~0020869

Fixed with a6b35ee7d345aa11e0388733fb95f3a4d2e52180

Issue History

Date Modified Username Field Change
2024-01-11 16:59 fefe New Issue
2024-01-11 16:59 fefe Status new => assigned
2024-01-11 16:59 fefe Assigned To => Christian Grothoff
2024-01-11 17:01 fefe Note Added: 0020863
2024-01-11 17:14 oec Assigned To Christian Grothoff => oec
2024-01-12 11:59 oec Status assigned => resolved
2024-01-12 11:59 oec Resolution open => fixed
2024-01-12 11:59 oec Fixed in Version => git (master)
2024-01-12 11:59 oec Note Added: 0020869
2024-01-25 22:30 Christian Grothoff Fixed in Version git (master) => 0.9.4
2024-01-25 22:30 Christian Grothoff Target Version => 0.9.4
2024-03-07 20:49 Christian Grothoff Status resolved => closed