View Issue Details

IDProjectCategoryView StatusLast Update
0008057Talerauditorpublic2024-03-07 20:47
Reporterfefe Assigned ToChristian Grothoff  
PrioritylowSeveritytrivialReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008057: TALER_AUDITOR_get_config: superfluous GNUNET_free
DescriptionThis is in src/lib/auditor_api_get_config.c:

219 struct TALER_AUDITOR_GetConfigHandle *
220 TALER_AUDITOR_get_config (struct GNUNET_CURL_Context *ctx,
221 const char *url,
222 TALER_AUDITOR_ConfigCallback config_cb,
223 void *config_cb_cls)
224 {
225 struct TALER_AUDITOR_GetConfigHandle *auditor;
226 CURL *eh;
227
228 auditor = GNUNET_new (struct TALER_AUDITOR_GetConfigHandle);
229 auditor->config_cb = config_cb;
230 auditor->config_cb_cls = config_cb_cls;
231 auditor->ctx = ctx;
232 auditor->vr_url = TALER_url_join (url,
233 "config",
234 NULL);
235 if (NULL == auditor->vr_url)
236 {
237 GNUNET_break (0);
238 GNUNET_free (auditor->vr_url);
239 GNUNET_free (auditor);
240 return NULL;
241 }

When we get to line 238, auditor->vr_url is NULL. We just checked for that.
TagsNo tags attached.

Relationships

child of 0008112 assignedfefe Merchant security review 

Activities

Christian Grothoff

2024-01-10 16:13

manager   ~0020858

Fixed in 17522251..bcaddc72

Issue History

Date Modified Username Field Change
2024-01-10 16:08 fefe New Issue
2024-01-10 16:08 fefe Status new => assigned
2024-01-10 16:08 fefe Assigned To => Christian Grothoff
2024-01-10 16:13 Christian Grothoff Status assigned => resolved
2024-01-10 16:13 Christian Grothoff Resolution open => fixed
2024-01-10 16:13 Christian Grothoff Fixed in Version => 0.9.4
2024-01-10 16:13 Christian Grothoff Note Added: 0020858
2024-01-10 16:13 Christian Grothoff Product Version => git (master)
2024-01-10 16:13 Christian Grothoff Target Version => 0.9.4
2024-01-18 23:33 Christian Grothoff Relationship added child of 0008112
2024-03-07 20:47 Christian Grothoff Status resolved => closed