View Issue Details

IDProjectCategoryView StatusLast Update
0008019Talerexchangepublic2024-03-07 20:47
ReporterFlorian Dold Assigned ToChristian Grothoff  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008019: taler-terms-generator does not respect file system hierarchy standard
DescriptionThe Debian package installs the sample ToS files in /usr/share/taler/terms. That is completely fine.

However, the taler-terms-generator then generates files based on that also in /usr/share/taler/terms. That violates the file system hierarchy standard, because /usr/share is supposed to be read-only. Instead, the ToS should be served from /etc/taler/terms or /var/lib/taler/terms.

While this sounds like nitpicking, it has caused real issues before: Sandcastle-ng mounts /usr/share/taler/terms as a volume, so the results of taler-terms-generator can be cached between runs. But this also means that newer versions of the sample ToS shipped with the package will not be picked up.

Furthermore, the current path encourages users to make modifications that then will be overwritten by package updates. We should not mix up immutable data that is shipped with the package and generated or user-modified files!
TagsNo tags attached.


Christian Grothoff

2023-12-22 07:36

manager   ~0020787

Should be fixed with 5c3c1b68..afdccca7

Issue History

Date Modified Username Field Change
2023-12-20 09:42 Florian Dold New Issue
2023-12-20 09:42 Florian Dold Status new => assigned
2023-12-20 09:42 Florian Dold Assigned To => Christian Grothoff
2023-12-22 07:36 Christian Grothoff Note Added: 0020787
2023-12-22 07:36 Christian Grothoff Status assigned => resolved
2023-12-22 07:36 Christian Grothoff Resolution open => fixed
2023-12-22 07:37 Christian Grothoff Product Version => git (master)
2023-12-22 07:37 Christian Grothoff Fixed in Version => 0.9.4
2024-03-07 20:47 Christian Grothoff Status resolved => closed