View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007968 | Taler | libeufin-bank | public | 2023-10-23 19:11 | 2023-11-29 01:30 |
| Reporter | sebasjm | Assigned To | Antoine A | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.9.4 | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007968: changes in the spec of core bank api | ||||
| Description | Done (in api-common spec) 1. 415 media not found, spec when this is returned. Maybe http-commons? Done 2. admin should be able to change other user password, without using old_password Done 3. user should be required to send old_password on change password request Done (409 or 401 status with code) 4. update account, on FORBIDDEN: add the code spec that tells if change-legal-name or admin Done 5. create transaction should return 204 instead of 200 Done 6. abort withdrawal should return 204 instead of 200 Done 7. confirm withdrawal should return 204 instead of 200 Done 8. create cashout: add the code response spec that tells when - contact info is missing - no enough balance - exchange rate is wrong</del> Done (401 status with code) 9. create cashout on 503 should spec the code to differentiate - no tan support - no cashout support Done (501 status) 10. return 503 when for every cashout endpoint and there is no cashout support Done 11. add pagination query parameters to GET /accounts/$USERNAME/cashouts Done 12. add pagination query parameters to GET /cashouts Done 13. add pagination query parameters to GET /public-accounts Done (401 status) 14. when trying to get info account from account using another account (and "another" is not admin), return 403 "Forbidden" Done 15. make "delta" param optional GET /accounts/${account_name}/transactions, currently response status:400 { code: 25 } and the docs says that default is 5 Done (this client should ask for a message an put it in the payto) 16. in the endpoint "/accounts/${account_name}/transactions" method GET, and response status 400: spec error code that differentiate between: - request invalid (what does this mean to the user? ) - payto:// with unacceptable features. (maybe the code could be specific to the feature/field?) Done (409 or 401 status with code) 17. when creating account and getting 403 Forbidden, spec the code that differentiate between: - reserve username attempted - unauthorized user Done (409 status with code) 18. when change password spec the code to differentiate between wrong "old_password" or "user not allowed" Done (409 status with code) 19. on creating withdrawal endpint, "Forbidden" is used when there is not enough balance for the requested amount. Change to "PreconditionFailed" Done (always supported) 20. when monitor service is not supported, return 503 instead of 404 | ||||
| Tags | No tags attached. | ||||
|
|
also Done 21. add "allowRegistrations" in /config, should be false if only admin can create accounts, true if the system is open for registrations Done 22. withdrawal operation creation should spec 404 when the account is not found https://docs.taler.net/core/api-corebank.html#post-$BANK_API_BASE_URL-accounts-$account_name-withdrawals |
|
|
Done (409 status with code) 23. making a tx to an not existing account returns 404 , this may get confused if the origin account is not found (also returns 404) it should be another error code https://docs.taler.net/core/api-corebank.html#post-$BANK_API_BASE_URL-accounts-$account_name-transactions |
|
|
Done 24. after aborting a withdrawal, when i try to confirm I get 422 and the error es confusing for the user since the withdrawal is already aborted, the message should be "already aborted" and now I'm getting "you need to complete the operation before confirm" |
|
|
Done 25. when the transaction or withdrawal operation is made about the debit threshold there should be a taler error code that indicate that this is the case instead of TALER_EC_BANK_UNALLOWED_DEBIT, so the message to the user can be nicer |
|
|
Done 26. response of POST ${BANK_API_BASE_URL}/accounts/${USERNAME}/transactions after successful creation of a transaction, return the txId so the bank spa can show tx details of the tx created |
|
|
Done(/cashin-rate and /cashout-rate with status and code) 27. change /cashout-rate to /conversion-rate and when the result is BadRequest add which error code is returned for: * calculation is not correct * the requested currency was not supported |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-10-23 19:11 | sebasjm | New Issue | |
| 2023-10-23 19:11 | sebasjm | Status | new => assigned |
| 2023-10-23 19:11 | sebasjm | Assigned To | => Antoine A |
| 2023-10-30 23:02 | sebasjm | Note Added: 0020613 | |
| 2023-10-30 23:12 | sebasjm | Note Added: 0020614 | |
| 2023-10-30 23:15 | sebasjm | Note Added: 0020615 | |
| 2023-10-30 23:16 | sebasjm | Severity | minor => major |
| 2023-10-30 23:16 | sebasjm | Product Version | git (master) => 0.9.4 |
| 2023-10-30 23:16 | sebasjm | Target Version | git (master) => 0.9.4 |
| 2023-10-31 15:33 | Antoine A | Description Updated | |
| 2023-10-31 15:34 | Antoine A | Description Updated | |
| 2023-11-03 21:12 | sebasjm | Note Added: 0020625 | |
| 2023-11-03 21:29 | sebasjm | Note Added: 0020626 | |
| 2023-11-03 21:45 | sebasjm | Note Added: 0020627 | |
| 2023-11-10 15:00 | Antoine A | Description Updated | |
| 2023-11-10 15:05 | Antoine A | Description Updated | |
| 2023-11-10 15:06 | Antoine A | Note Edited: 0020613 | |
| 2023-11-10 15:07 | Antoine A | Note Edited: 0020614 | |
| 2023-11-10 15:07 | Antoine A | Note Edited: 0020615 | |
| 2023-11-10 15:07 | Antoine A | Note Edited: 0020625 | |
| 2023-11-10 15:08 | Antoine A | Note Edited: 0020627 | |
| 2023-11-14 00:59 | Antoine A | Description Updated | |
| 2023-11-14 12:13 | Antoine A | Description Updated | |
| 2023-11-14 13:38 | Antoine A | Note Edited: 0020626 | |
| 2023-11-14 13:51 | Antoine A | Status | assigned => resolved |
| 2023-11-14 13:51 | Antoine A | Resolution | open => fixed |
| 2023-11-29 01:28 | Christian Grothoff | Target Version | 0.9.4 => 0.9.3 |
| 2023-11-29 01:29 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-11-29 01:30 | Christian Grothoff | Status | resolved => closed |
