View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007949 | Taler | specification | public | 2023-10-05 12:47 | 2025-08-31 17:09 |
| Reporter | sebasjm | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0007949: unified set of parameters for endpoint with pagination | ||||
| Description | current state: delta and start https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-orders limit and offset https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-transfers https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-rewards proposal: if we want the result to be paginated it will be enough to have * offset: id of the element in the list ( equals product_id in products or order_id in orders) * limit: max number of elements in the list if we need the result to be ordered by some criteria defined by the client (other than the default) * order: criteria name in increasing order, a hyphen symbol at the start indicate decreasing the criteria for witch the order is possible should be explicitly indicated in the endpoint documentation (since it will match some index in the db), for example: - creation_time - last_update_time - execution_time Additional parameters are considered filters and every filter has its own semantic. Like "before", "after" in transfers or "date_s" in orders. modification to the current API 1 names are always use offset and limit 2 offset is always the row id or element id 3 order is specified as a parameter, not in the limit parameter as a hyphen This will also allow the SPA client to have sorting columns in the table UI in the future. | ||||
| Tags | No tags attached. | ||||
| We will keep the minus ("-") for in the "limit" to indicate going backwards, that's IMO still nice and already uniform. The /private/orders endpoint already supports the new offset/limit style. However, *bank* APIs still use those, so that still needs to be fixed. | |
| Bank code is now also unified in e28159fc7..316caf603 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-10-05 12:47 | sebasjm | New Issue | |
| 2023-10-05 12:47 | sebasjm | Status | new => assigned |
| 2023-10-05 12:47 | sebasjm | Assigned To | => Christian Grothoff |
| 2023-10-05 14:43 | Christian Grothoff | Assigned To | Christian Grothoff => |
| 2023-10-05 14:43 | Christian Grothoff | Status | assigned => implementing |
| 2024-01-12 13:02 | Christian Grothoff | Category | merchant backend API (HTTP specification) => specification |
| 2024-12-07 22:15 | Christian Grothoff | Relationship added | related to 0007948 |
| 2024-12-07 22:15 | Christian Grothoff | Product Version | post-1.0 => git (master) |
| 2024-12-07 22:15 | Christian Grothoff | Target Version | post-1.0 => 1.5 |
| 2025-07-03 13:17 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2025-07-03 13:17 | Christian Grothoff | Status | implementing => assigned |
| 2025-07-03 15:09 | Christian Grothoff | Note Added: 0025403 | |
| 2025-07-03 15:27 | Christian Grothoff | Status | assigned => informing |
| 2025-07-03 15:27 | Christian Grothoff | Resolution | open => fixed |
| 2025-07-03 15:27 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |
| 2025-07-03 15:27 | Christian Grothoff | Target Version | 1.5 => 1.0 stretch goals |
| 2025-07-03 15:28 | Christian Grothoff | Note Added: 0025405 | |
| 2025-08-31 17:09 | Christian Grothoff | Status | informing => closed |