View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007933 | Taler | wallet (Android App) | public | 2023-09-04 21:37 | 2023-09-23 15:09 |
| Reporter | avalos | Assigned To | avalos | ||
| Priority | normal | Severity | major | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Platform | arm64 | OS | LineageOS | OS Version | 18.1 |
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007933: QR codes for p2p transactions should only show after they're valid (registered with exchange) | ||||
| Description | WHAT HAPPENS NOW It is often the case that when two users want to transfer money to each other, they initiate a p2p payment (either pull or push), and one of them scans the QR code immediately as soon as it appears in the other user's wallet. Doing this often results in an error (shown below) because the contract for the QR code hasn't yet been generated in the exchange at the moment the user attempts to pay it. Retrying after a few seconds or minutes should result in a successful payment (or maybe not). { "code": 7005, "hint": "Unexpected HTTP status 404 in response", "message": null, "when": { "t_ms": 1692380314039 }, "requestUrl": "https://taler.tschunk.shop/contracts/23Y0W7E5WYBYMJ887TT2VSW1181DDMECF3NE68Q3DRHTZ9HZ4Y6G", "requestMethod": "GET", "httpStatusCode": 404, "errorResponse": { "code": 1950, "hint": "The exchange does not know a contract under the given contract public key." } } WHAT SHOULD HAPPEN The QR code for a p2p payment should not appear in the wallet apps until it is actually valid. | ||||
| Tags | No tags attached. | ||||
|
|
Is there a wallet notification we can listen for this? |
|
|
good catch i think that the status = PeerPullPaymentInitiationStatus.PendingReady should be enough and if the transaction you have in the screen is still in a prev state you can wait for NotificationType.TransactionStateTransition with id == the current tx id |
|
|
You mean, "txState":{"major":"pending","minor":"ready"} ? |
|
|
Possibly fixed in dev/ivan-avalos/master, for both pull and push payments. |
|
|
already implemented for iOS. |
|
|
Fixed in 7392cd72ddd3406369b13bd8a7f57fb18822eaa2. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-09-04 21:37 | avalos | New Issue | |
| 2023-09-04 21:37 | avalos | Status | new => assigned |
| 2023-09-04 21:37 | avalos | Assigned To | => avalos |
| 2023-09-04 21:57 | avalos | Note Added: 0020491 | |
| 2023-09-05 13:05 | sebasjm | Note Added: 0020498 | |
| 2023-09-05 17:50 | avalos | Note Added: 0020503 | |
| 2023-09-05 17:55 | avalos | Note Added: 0020504 | |
| 2023-09-06 06:43 | MarcS | Summary | QR codes for p2p transactions should only show until valid => QR codes for p2p transactions should only show after they're valid (registered with exchange) |
| 2023-09-06 08:16 | MarcS | Note Added: 0020506 | |
| 2023-09-08 04:33 | avalos | Status | assigned => resolved |
| 2023-09-08 04:33 | avalos | Resolution | open => fixed |
| 2023-09-08 04:33 | avalos | Note Added: 0020509 | |
| 2023-09-23 15:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 15:09 | Christian Grothoff | Status | resolved => closed |
