View Issue Details

IDProjectCategoryView StatusLast Update
0007810Talerwallet-corepublic2023-11-29 01:30
ReporterFlorian Dold Assigned ToChristian Grothoff  
PriorityurgentSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007810: support conversion service URL and regex validation for /wire
DescriptionWe also need to distinguish between withdrawals and deposits, as in the conversion case, different restrictions for the payto:// URI apply.
TagsNo tags attached.


Christian Grothoff

2023-04-22 22:08

manager   ~0020126

Last edited: 2023-04-22 22:09

API change for /wire specified in docs.git -- 43a3dca..d3102b7.

Once implemented, we MUST bump the protocol to "15:0:0" and add a (transient) protocol-version based switch in libtalerexchange.

Christian Grothoff

2023-05-02 12:09

manager   ~0020172

This is largely implemented (exchange, merchant, documentation). Wallet is missing (=> assigning to Florian). What is still missing is that the merchant (and wallet) currently ignores debit restrictions imposed by the exchange and would be perfectly happy to accept deposits for coins from exchanges where the exchange doesn't actually accept the merchant's bank account.

To fix this, we need a working regex evaluator for this style of regex AND to modify the pay logic to actually check.

Florian Dold

2023-11-22 18:21

manager   ~0020657

In wallet-core, we now support:
* using the conversion_url during (manual only!) withdrawal, allowing the UIs to display the external currency that the user needs to transfer to withdraw the regional currency
* checking the debit restrictions on deposit

However, obviously the wallet can't check deposit restrictions when doing a payment, since it doesn't know the payto URI of the merchant.
What was the design here? I remember we discussed *something* here, but not sure what it was exactly anymore.

Florian Dold

2023-11-22 18:28

manager   ~0020658

(After giving it more thought, I think that the merchant must only include exchanges in the contract terms where the merchant account is allowed by the debit restrictions of the exchange.)

Christian Grothoff

2023-11-22 20:04

manager   ~0020659

Yes, and the merchant does so. Why did you re-assign to me?

Issue History

Date Modified Username Field Change
2023-04-22 17:54 Florian Dold New Issue
2023-04-22 17:54 Florian Dold Status new => assigned
2023-04-22 17:54 Florian Dold Assigned To => Christian Grothoff
2023-04-22 18:11 Florian Dold Description Updated
2023-04-22 22:08 Christian Grothoff Note Added: 0020126
2023-04-22 22:09 Christian Grothoff Note Edited: 0020126
2023-05-02 12:09 Christian Grothoff Note Added: 0020172
2023-05-02 12:09 Christian Grothoff Assigned To Christian Grothoff => Florian Dold
2023-06-21 18:22 Florian Dold Target Version 0.9.3 => 0.9.4
2023-07-16 16:05 Christian Grothoff Priority normal => urgent
2023-11-03 00:40 Christian Grothoff Category exchange => wallet-core
2023-11-13 18:39 Florian Dold Assigned To Florian Dold => Christian Grothoff
2023-11-13 18:39 Florian Dold Assigned To Christian Grothoff => Florian Dold
2023-11-22 18:19 Florian Dold Assigned To Florian Dold => Christian Grothoff
2023-11-22 18:21 Florian Dold Note Added: 0020657
2023-11-22 18:28 Florian Dold Note Added: 0020658
2023-11-22 20:04 Christian Grothoff Note Added: 0020659
2023-11-22 20:15 Christian Grothoff Status assigned => resolved
2023-11-22 20:15 Christian Grothoff Resolution open => fixed
2023-11-22 20:15 Christian Grothoff Fixed in Version => 0.9.4
2023-11-29 01:28 Christian Grothoff Target Version 0.9.4 => 0.9.3
2023-11-29 01:29 Christian Grothoff Fixed in Version 0.9.4 => 0.9.3
2023-11-29 01:30 Christian Grothoff Status resolved => closed