View Issue Details

IDProjectCategoryView StatusLast Update
0007695Talerwallet (WebExtension)public2023-02-21 16:39
ReporterFlorian Dold Assigned Tosebasjm  
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.2Fixed in Version0.9.2 
Summary0007695: all transactions must be deletable/forgettable, at least in dev mode
DescriptionIt's important that we always allow deleting transactions (at least in dev mode), so we never end up with a wallet that has some broken transaction (say, from some test deployment) in it.
TagsNo tags attached.



2023-02-14 14:45

developer   ~0019833

Forget button is always going to be shown if it is in an end state

const transactionStillActive =
    transaction.extendedStatus !== ExtendedStatus.Aborted &&
    transaction.extendedStatus !== ExtendedStatus.Done &&
    transaction.extendedStatus !== ExtendedStatus.Failed;

If is active, the delete button is shown but just for tx that has cancelTransaction implemented

const hasCancelTransactionImplemented =
    transaction.type === TransactionType.Payment;

Florian Dold

2023-02-16 23:00

manager   ~0019855

Does the UI support aborting (and force-aborting when already in the aborting state)? If so, we can close this, because once wallet-core fully implements abort and forced aborts for each transaction, we'll always be able to eventually forget the transaction.

See DD37 for details.


2023-02-17 20:29

developer   ~0019871

fixed a45759e2adfd3bd6955d4135ee5e7ead1eac826c

making all tx to show forget/delete-tx button in devmode

Issue History

Date Modified Username Field Change
2023-02-14 14:39 Florian Dold New Issue
2023-02-14 14:39 Florian Dold Status new => assigned
2023-02-14 14:39 Florian Dold Assigned To => sebasjm
2023-02-14 14:45 sebasjm Note Added: 0019833
2023-02-14 14:48 sebasjm Assigned To sebasjm => Florian Dold
2023-02-16 23:00 Florian Dold Assigned To Florian Dold => sebasjm
2023-02-16 23:00 Florian Dold Status assigned => feedback
2023-02-16 23:00 Florian Dold Note Added: 0019855
2023-02-17 20:29 sebasjm Note Added: 0019871
2023-02-17 20:29 sebasjm Status feedback => resolved
2023-02-17 20:29 sebasjm Resolution open => fixed
2023-02-21 16:39 Christian Grothoff Fixed in Version => 0.9.2
2023-02-21 16:39 Christian Grothoff Status resolved => closed
2023-04-13 20:37 Florian Dold Category wallet (WebExtensions) => wallet (WebExtension)