View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007654 | GNUnet | other | public | 2023-01-30 00:51 | 2023-06-01 20:26 |
Reporter | ulfvonbelow | Assigned To | schanzen | ||
Priority | normal | Severity | trivial | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | Git master | ||||
Target Version | 0.19.4 | Fixed in Version | 0.19.4 | ||
Summary | 0007654: Miscellaneous comment typos, misspellings, etc. | ||||
Description | See patch. | ||||
Additional Information | Patch attached. Random collection of distracting typos I came across in my quest to make the test suite pass with sanitizers enabled. | ||||
Tags | patch | ||||
Attached Files | 0001-Miscellaneous-mostly-comment-typo-fixes.patch (8,563 bytes)
From 6eae2260c8bb904460d00393a156802843bfc64f Mon Sep 17 00:00:00 2001 From: ulfvonbelow <strilen@tilde.club> Date: Sun, 29 Jan 2023 10:22:14 -0600 Subject: [PATCH] -Miscellaneous mostly-comment typo fixes. The message in src/testbed/testbed_api_hosts.c was phrased a little strangely, so I changed that too. --- src/consensus/gnunet-consensus-profiler.c | 2 +- src/include/gnunet_mq_lib.h | 2 +- src/include/gnunet_testbed_service.h | 4 ++-- src/secretsharing/gnunet-secretsharing-profiler.c | 2 +- src/setu/gnunet-service-setu.c | 2 +- src/testbed/test_testbed_api.c | 2 +- src/testbed/test_testbed_api_test.c | 2 +- src/testbed/testbed_api.c | 2 +- src/testbed/testbed_api_hosts.c | 6 +++--- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/consensus/gnunet-consensus-profiler.c b/src/consensus/gnunet-consensus-profiler.c index 07a536a2d..535837008 100644 --- a/src/consensus/gnunet-consensus-profiler.c +++ b/src/consensus/gnunet-consensus-profiler.c @@ -380,7 +380,7 @@ disconnect_adapter (void *cls, void *op_result) /** * Callback to be called when the requested peer information is available * - * @param cb_cls the closure from GNUNET_TETSBED_peer_get_information() + * @param cb_cls the closure from GNUNET_TESTBED_peer_get_information() * @param op the operation this callback corresponds to * @param pinfo the result; will be NULL if the operation has failed * @param emsg error message if the operation has failed; will be NULL if the diff --git a/src/include/gnunet_mq_lib.h b/src/include/gnunet_mq_lib.h index 95e8c619b..f424c49c2 100644 --- a/src/include/gnunet_mq_lib.h +++ b/src/include/gnunet_mq_lib.h @@ -994,7 +994,7 @@ GNUNET_MQ_destroy_notify_cancel ( * Call the message message handler that was registered * for the type of the given message in the given message queue. * - * This function is indented to be used for the implementation + * This function is intended to be used for the implementation * of message queues. * * @param mq message queue with the handlers diff --git a/src/include/gnunet_testbed_service.h b/src/include/gnunet_testbed_service.h index acd87e2cd..2aeafc977 100644 --- a/src/include/gnunet_testbed_service.h +++ b/src/include/gnunet_testbed_service.h @@ -428,7 +428,7 @@ typedef void * GNUNET_TESTBED_ControllerStatusCallback() * * @param trusted_ip the ip address of the controller which will be set as TRUSTED - * HOST(all connections form this ip are permitted by the testbed) when + * HOST(all connections from this ip are permitted by the testbed) when * starting testbed controller at host. This can either be a single ip * address or a network address in CIDR notation. * @param host the host where the controller has to be started. CANNOT be NULL. @@ -752,7 +752,7 @@ struct GNUNET_TESTBED_PeerInformation * Callback to be called when the requested peer information is available * The peer information in the callback is valid until the operation 'op' is canceled. * - * @param cb_cls the closure from GNUNET_TETSBED_peer_get_information() + * @param cb_cls the closure from GNUNET_TESTBED_peer_get_information() * @param op the operation this callback corresponds to * @param pinfo the result; will be NULL if the operation has failed * @param emsg error message if the operation has failed; will be NULL if the diff --git a/src/secretsharing/gnunet-secretsharing-profiler.c b/src/secretsharing/gnunet-secretsharing-profiler.c index 76bba0bc9..432d6da89 100644 --- a/src/secretsharing/gnunet-secretsharing-profiler.c +++ b/src/secretsharing/gnunet-secretsharing-profiler.c @@ -446,7 +446,7 @@ session_disconnect_adapter (void *cls, void *op_result) /** * Callback to be called when the requested peer information is available * - * @param cb_cls the closure from GNUNET_TETSBED_peer_get_information() + * @param cb_cls the closure from GNUNET_TESTBED_peer_get_information() * @param op the operation this callback corresponds to * @param pinfo the result; will be NULL if the operation has failed * @param emsg error message if the operation has failed; will be NULL if the diff --git a/src/setu/gnunet-service-setu.c b/src/setu/gnunet-service-setu.c index ad81dd28d..d3768b624 100644 --- a/src/setu/gnunet-service-setu.c +++ b/src/setu/gnunet-service-setu.c @@ -5067,7 +5067,7 @@ handle_client_evaluate (void *cls, #endif /* Advance generation values, so that - mutations won't interfer with the running operation. */ + mutations won't interfere with the running operation. */ op->set = set; op->generation_created = set->current_generation; advance_generation (set); diff --git a/src/testbed/test_testbed_api.c b/src/testbed/test_testbed_api.c index a46a7596a..ffc98f42c 100644 --- a/src/testbed/test_testbed_api.c +++ b/src/testbed/test_testbed_api.c @@ -265,7 +265,7 @@ service_connect_comp_cb (void *cls, /** * Callback to be called when the requested peer information is available * - * @param cb_cls the closure from GNUNET_TETSBED_peer_get_information() + * @param cb_cls the closure from GNUNET_TESTBED_peer_get_information() * @param op the operation this callback corresponds to * @param pinfo the result; will be NULL if the operation has failed * @param emsg error message if the operation has failed; will be NULL if the diff --git a/src/testbed/test_testbed_api_test.c b/src/testbed/test_testbed_api_test.c index f451c6555..1728badc1 100644 --- a/src/testbed/test_testbed_api_test.c +++ b/src/testbed/test_testbed_api_test.c @@ -118,7 +118,7 @@ do_abort (void *cls) /** * Callback to be called when the requested peer information is available * - * @param cb_cls the closure from GNUNET_TETSBED_peer_get_information() + * @param cb_cls the closure from GNUNET_TESTBED_peer_get_information() * @param op the operation this callback corresponds to * @param pinfo the result; will be NULL if the operation has failed * @param emsg error message if the operation has failed; will be NULL if the diff --git a/src/testbed/testbed_api.c b/src/testbed/testbed_api.c index 2ae0a1703..ee7aac9b7 100644 --- a/src/testbed/testbed_api.c +++ b/src/testbed/testbed_api.c @@ -1945,7 +1945,7 @@ GNUNET_TESTBED_overlay_write_topology_to_file ( * want to use this in testing * * @param trusted_ip the ip address of the controller which will be set as TRUSTED - * HOST(all connections form this ip are permitted by the testbed) when + * HOST(all connections from this ip are permitted by the testbed) when * starting testbed controller at host. This can either be a single ip * address or a network address in CIDR notation. * @param hostname the hostname of the destination this message is intended for diff --git a/src/testbed/testbed_api_hosts.c b/src/testbed/testbed_api_hosts.c index 84871eb70..2919b8b75 100644 --- a/src/testbed/testbed_api_hosts.c +++ b/src/testbed/testbed_api_hosts.c @@ -792,7 +792,7 @@ free_argv (char **argv) * be set locally in the function from its parameteres. If the environmental * variable is not found then it defaults to `ssh -o BatchMode=yes -o * NoHostAuthenticationForLocalhost=yes -o StrictHostkeyChecking=no -o - * PasswordAuthentication=noc' + * PasswordAuthentication=no' * * @param port the destination port number * @param hostname the hostname of the target host @@ -872,7 +872,7 @@ gen_rsh_args (const char *port, const char *hostname, const char *username) /** * Generates the arguments needed for executing the given binary in a remote * shell. Builds the arguments from the environmental variable - * GNUNET_TETSBED_RSH_CMD_SUFFIX. If the environmental variable is not found, + * GNUNET_TESTBED_RSH_CMD_SUFFIX. If the environmental variable is not found, * only the given binary name will be present in the returned arguments * * @param append_args the arguments to append after generating the suffix @@ -1054,7 +1054,7 @@ GNUNET_TESTBED_controller_start (const char *trusted_ip, host->locked = GNUNET_YES; API_VIOLATION ( GNUNET_NO == host->controller_started, - "Attempting to start a controller on a host which is already started a controller"); + "Attempting to start a controller on a host on which a controller is already started"); cp = GNUNET_new (struct GNUNET_TESTBED_ControllerProc); if (0 == GNUNET_TESTBED_host_get_id_ (host)) { -- 2.38.1 | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2023-01-30 00:51 | ulfvonbelow | New Issue | |
2023-01-30 00:51 | ulfvonbelow | Tag Attached: patch | |
2023-01-30 00:51 | ulfvonbelow | File Added: 0001-Miscellaneous-mostly-comment-typo-fixes.patch | |
2023-02-06 05:51 | schanzen | Assigned To | => schanzen |
2023-02-06 05:51 | schanzen | Status | new => resolved |
2023-02-06 05:51 | schanzen | Resolution | open => fixed |
2023-02-06 05:51 | schanzen | Fixed in Version | => 0.19.4 |
2023-02-06 06:19 | schanzen | Target Version | => 0.19.4 |
2023-06-01 20:26 | schanzen | Note Added: 0020216 | |
2023-06-01 20:26 | schanzen | Status | resolved => closed |