View Issue Details

IDProjectCategoryView StatusLast Update
0007652GNUnetdatacache librarypublic2023-06-01 20:26
Reporterulfvonbelow Assigned Toschanzen  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.19.4Fixed in Version0.19.4 
Summary0007652: Memory leak in datacache tests
Descriptionplugin_name isn't freed.
Steps To Reproduce./configure --enable-sanitizer
make
make install
make check
Additional InformationPatch attached.
Tagspatch
Attached Files
0001-DATACACHE-fix-memory-leaks-in-tests.patch (1,153 bytes)   
From eafdd3995caef481058a985d90e2adc39a9cc6ca Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sun, 29 Jan 2023 07:10:14 -0600
Subject: [PATCH] -DATACACHE: fix memory leaks in tests.

This allows us to use sanitizers to find bugs that matter.
---
 src/datacache/test_datacache.c       | 1 +
 src/datacache/test_datacache_quota.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/datacache/test_datacache.c b/src/datacache/test_datacache.c
index fd5a5f54c..5392f6b17 100644
--- a/src/datacache/test_datacache.c
+++ b/src/datacache/test_datacache.c
@@ -198,6 +198,7 @@ main (int argc, char *argv[])
     fprintf (stderr,
              "Missed some testcases: %d\n",
              ok);
+  GNUNET_free (plugin_name);
   return ok;
 }
 
diff --git a/src/datacache/test_datacache_quota.c b/src/datacache/test_datacache_quota.c
index 994147a64..0ad7fb8a4 100644
--- a/src/datacache/test_datacache_quota.c
+++ b/src/datacache/test_datacache_quota.c
@@ -186,6 +186,7 @@ main (int argc,
     fprintf (stderr,
              "Missed some testcases: %d\n",
              ok);
+  GNUNET_free (plugin_name);
   return ok;
 }
 
-- 
2.38.1

Activities

schanzen

2023-06-01 20:26

administrator   ~0020218

released some time ago

Issue History

Date Modified Username Field Change
2023-01-30 00:49 ulfvonbelow New Issue
2023-01-30 00:49 ulfvonbelow Tag Attached: patch
2023-01-30 00:49 ulfvonbelow File Added: 0001-DATACACHE-fix-memory-leaks-in-tests.patch
2023-02-06 05:52 schanzen Assigned To => schanzen
2023-02-06 05:52 schanzen Status new => resolved
2023-02-06 05:52 schanzen Resolution open => fixed
2023-02-06 05:52 schanzen Fixed in Version => 0.19.4
2023-02-06 06:19 schanzen Target Version => 0.19.4
2023-06-01 20:26 schanzen Note Added: 0020218
2023-06-01 20:26 schanzen Status resolved => closed